-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #206: Fix broken insets since targeting Android 15. #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
caarmen
force-pushed
the
issue-206-fix-app-bar-insets
branch
from
October 26, 2024 23:19
811ae53
to
ef8c5e1
Compare
|
caarmen
changed the title
Issue #206: Fix
Issue #206: Fix broken insets since targeting Android 15.
Oct 27, 2024
AppBarLayout
insets.
|
We're hitting this behavior change when targeting Android 15: https://developer.android.com/about/versions/15/behavior-changes-15#not-edge-to-edge The documentation says: > you need to add android:fitsSystemWindows="true" if using AppBarLayout. Also apply a code snippet to various views: to ensure that the top and bottom aren't hidden under the system bars.
To do this, draw a view with our app's color, and make it the size of the status bar.
caarmen
force-pushed
the
issue-206-fix-app-bar-insets
branch
from
October 27, 2024 01:06
b8d40ac
to
591879f
Compare
|
|
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Fix
AppBarLayout
insets.We're hitting this behavior change when targeting Android 15: https://developer.android.com/about/versions/15/behavior-changes-15#not-edge-to-edge
The documentation says:
Also:
AppBarLayout
: to ensure that the top and bottom aren't hidden under the system bars.