Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #206: Fix broken insets since targeting Android 15. #208

Merged
merged 3 commits into from
Oct 27, 2024

Conversation

caarmen
Copy link
Owner

@caarmen caarmen commented Oct 26, 2024

Issue:

Fix AppBarLayout insets.

We're hitting this behavior change when targeting Android 15: https://developer.android.com/about/versions/15/behavior-changes-15#not-edge-to-edge

The documentation says:

you need to add android:fitsSystemWindows="true" if using AppBarLayout.

Also:

  • Apply a code snippet to various other screens not using AppBarLayout: to ensure that the top and bottom aren't hidden under the system bars.
  • Make the system status bar have our app's theme color. To do this, draw a view with our app's color, and make it the size of the status bar.
1.30.7 1.30.8 This PR
Android 15 list image image image
Android 15 settings image image image
Android 5.0 list image image image
Android 5.0 settings image image image

Copy link

Overall Project 80.39% 🍏

There is no coverage information present for the Files changed

@caarmen caarmen force-pushed the issue-206-fix-app-bar-insets branch from 811ae53 to ef8c5e1 Compare October 26, 2024 23:19
Copy link

Overall Project 80.14% -0.05% 🍏
Files changed 89.19% 🍏

File Coverage
InsetsFix.kt 100% 🍏
AboutActivity.kt 82.62% -0.95%
LicenseActivity.kt 82.06% -1.79%
SettingsActivity.kt 73.79% 🍏

@caarmen caarmen changed the title Issue #206: Fix AppBarLayout insets. Issue #206: Fix broken insets since targeting Android 15. Oct 27, 2024
Copy link

Overall Project 80.46% -0.05% 🍏
Files changed 91.58% 🍏

File Coverage
InsetsFix.kt 100% 🍏
AboutActivity.kt 82.62% -0.95%
LicenseActivity.kt 82.06% -1.79%
SettingsActivity.kt 73.79% 🍏

We're hitting this behavior change when targeting Android 15: https://developer.android.com/about/versions/15/behavior-changes-15#not-edge-to-edge

The documentation says:
> you need to add android:fitsSystemWindows="true" if using AppBarLayout.

Also apply a code snippet to various views: to ensure that the top and bottom aren't hidden under the system bars.
To do this, draw a view with our app's color, and make it the size of the status bar.
@caarmen caarmen force-pushed the issue-206-fix-app-bar-insets branch from b8d40ac to 591879f Compare October 27, 2024 01:06
Copy link

Overall Project 80.46% -0.05% 🍏
Files changed 91.58% 🍏

File Coverage
InsetsFix.kt 100% 🍏
AboutActivity.kt 82.62% -0.95%
LicenseActivity.kt 82.06% -1.79%
SettingsActivity.kt 73.79% 🍏

Copy link

Overall Project 80.16% -0.05% 🍏
Files changed 91.58% 🍏

File Coverage
InsetsFix.kt 100% 🍏
AboutActivity.kt 82.62% -0.95%
LicenseActivity.kt 82.06% -1.79%
SettingsActivity.kt 73.79% 🍏

@caarmen caarmen merged commit 014511d into master Oct 27, 2024
2 of 3 checks passed
@caarmen caarmen deleted the issue-206-fix-app-bar-insets branch October 27, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant