Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bio auth on mac + package updates for 3.19.3/5 #1398

Merged
merged 17 commits into from
May 6, 2024
Merged

bio auth on mac + package updates for 3.19.3/5 #1398

merged 17 commits into from
May 6, 2024

Conversation

fossephate
Copy link
Contributor

Issue Number (if Applicable): Fixes #

Description

Please include a summary of the changes and which issue is fixed / feature is added.

Pull Request - Checklist

  • Initial Manual Tests Passed
  • Double check modified code and verify it with the feature/task requirements
  • Format code
  • Look for code duplication
  • Clear naming for variables and methods

@OmarHatem28 OmarHatem28 mentioned this pull request Apr 24, 2024
Merged
5 tasks
OmarHatem28
OmarHatem28 requested changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@OmarHatem28 OmarHatem28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok looks, good, just 1 comment, and the fix for the biometric auth getting disabled after a restart on Mac

lib/view_model/auth_view_model.dart Outdated Show resolved Hide resolved
OmarHatem28
OmarHatem28 requested changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@OmarHatem28 OmarHatem28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and please test it with backward compatibility as well
i.e have the app already running with some wallets, and then switch to this branch and build, and see if it will cause any issues or not

lib/view_model/edit_backup_password_view_model.dart Show resolved Hide resolved
@OmarHatem28 OmarHatem28 merged commit e5be737 into main May 6, 2024
@OmarHatem28 OmarHatem28 deleted the CW-394-mac-auth-2 branch May 6, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OmarHatem28 OmarHatem28 OmarHatem28 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fossephate @OmarHatem28