Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symfony 7 support #269

Merged
merged 1 commit into from
Jan 20, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions composer.json
Original file line number Diff line number Diff line change
@@ -6,10 +6,10 @@
"license": "MIT",
"require": {
"php": "^8.1",
"cakephp/console": "5.x-dev",
"cakephp/console": "^5.0",
"nette/utils": "^3.2",
"rector/rector": "0.19.0",
"symfony/string": "^6.0"
"rector/rector": "~0.19.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can try making this a version string again but lets hope rector just doesn't remove rules we are using again in a patch release...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far it works

"symfony/string": "^6.0 || ^7.0"
},
"autoload": {
"psr-4": {
4 changes: 2 additions & 2 deletions phpcs.xml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<?xml version="1.0"?>
<ruleset name="CakePHP Upgrade">
<config name="installed_paths" value="../../cakephp/cakephp-codesniffer" />
<config name="installed_paths" value="../../cakephp/cakephp-codesniffer"/>

<rule ref="CakePHP" />
<rule ref="CakePHP"/>

<exclude-pattern>src/Rector</exclude-pattern>
<exclude-pattern>tests/test_apps</exclude-pattern>
6 changes: 3 additions & 3 deletions phpunit.xml.dist
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
<?xml version="1.0" encoding="UTF-8"?>
<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
bootstrap="./tests/bootstrap.php"
bootstrap="tests/bootstrap.php"
xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.2/phpunit.xsd">

<testsuites>
<testsuite name="Upgrade Test Cases">
<directory>./tests/TestCase/</directory>
<testsuite name="upgrade">
<directory>tests/TestCase/</directory>
</testsuite>
</testsuites>