Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[story] Display story from WordPress #14

Merged
merged 10 commits into from
Oct 7, 2023
Merged

Conversation

Marcoss28
Copy link
Collaborator

What's new in this PR

Story Page displays a story from the Girls Write Now website (specifically "It's Carnival" story).
Using WordPress API, we can successfully pull stories from the Girls Write Now website and display them on our app (although unorganized and unformatted).

Relevant Links

https://girlswritenow.org/story/its-carnival/

Notion Sprint Task

https://www.notion.so/calblueprint/story-Display-story-from-WordPress-0bfd1a25d2db458f8749efd7ab51ff20?pvs=4
//: # 'Add the relevant Notion link(s) here'

Online sources

https://www.dreamhost.com/blog/tutorial-wp-rest-api/
https://www.npmjs.com/package/react-native-htmlview
//: # 'Optional - copy links to any tutorial or documentation that was useful to you when working on this PR'

Related PRs

How to review

Run the application and go to the Story page/tab. At the top should be the title along with other unrecognized icons as you scroll down. Scroll far enough and you can view the story. In a plain text format.
//: # 'The order in which to review files and what to expect when testing locally'

Next steps

Create a parser/formatter to organize content shown.
Create a method for choosing an arbitrary story to display.
//: # "What's NOT in this PR, doesn't work yet, and/or still needs to be done"

Tests Performed, Edge Cases

Screenshots

Screenshot 2023-10-02 at 5 28 49 PM
Screenshot 2023-10-02 at 5 28 53 PM
Screenshot 2023-10-02 at 5 28 58 PM
Screenshot 2023-10-02 at 5 29 00 PM

CC: @akshaynthakur

Copy link
Collaborator

@akshaynthakur akshaynthakur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Couple small changes, but nice job overall! Also, I changed it for you but for future PRs make sure to name them with the name I gave your task on Notion. This helps keep our naming convention consistent and clear

src/screens/StoryScreen.tsx Outdated Show resolved Hide resolved
src/screens/StoryScreen.tsx Outdated Show resolved Hide resolved
src/screens/StoryScreen.tsx Outdated Show resolved Hide resolved
@akshaynthakur akshaynthakur changed the title Marcos/wordpress story [story] Display story from WordPress Oct 3, 2023
Copy link
Collaborator

@akshaynthakur akshaynthakur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@akshaynthakur akshaynthakur merged commit d0a7f60 into main Oct 7, 2023
2 checks passed
@akshaynthakur akshaynthakur deleted the marcos/wordpressStory branch October 7, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants