[feat] Create a textinput component #39
Open
+569
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ut, complexity check, and toggle password visibility features
There was a problem hiding this comment.
looking great so far!! tysm rachael! 🤩
some comments
- make sure u import colors from figma into the styles/colors.ts folder!
- import the show/hide icon from figma and use absolute positioning to place it on top of the input (see my comment)
- we should merge in auth context and confirm password asap and rebase before merging this!
| font-size: 1rem; | ||
| font-weight: 500; | ||
| margin-bottom: 0.5rem; | ||
| color: darkgreen; |
There was a problem hiding this comment.
make sure you use the custom colors from figma. you can find this by going on dev mode and getting the hex code. Then, add the color to the styles/colors.ts folder and import it into this file and access the color here using
color: ${COLORS.darkGreen}
| transition: border-color 0.3s ease; | ||
|
|
||
| &:focus { | ||
| border-color: green; |
There was a problem hiding this comment.
flagging the color comment!
Comment on lines
+43
to
+51
| {type === 'password' && toggleVisibility && ( | ||
| <button | ||
| type="button" | ||
| onClick={toggleVisibility} | ||
| style={{ | ||
| marginBottom: '10px', | ||
| }} | ||
| > | ||
| {isVisible ? 'Hide' : 'Show'} |
There was a problem hiding this comment.
we want to import the Show and Hide icons from figma and add it to the project. in order to be consistent with the designs, this should also appear inside the Input bar.
To achieve this, chatGPT suggested this:
- Wrap the input and the button in a container.
- Use absolute positioning on the button to place it inside the input field on the right side.
you'll prob need to make some edits like this
const InputWrapper = styled.div`
position: relative;
width: 100%;
`;
const ShowHideButton = styled.button`
position: absolute;
right: 10px; // or whatever it is
top: 50%; // this line and...
transform: translateY(-50%); // this line help center the Button within input box
cursor: pointer;
`;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR 🧑🌾
Description
TextInputcomponent that highlights the border of the active input field in green.TextInputcomponent to style the input fields on the login and sign-up pages.Screenshots
Styled Log In and Sign Up pages
Selected Input
How to review
components/TextInputandcomponents/stylesfiles/loginand/signuppagesNext steps
Relevant links
Online sources
Related PRs
CC: @ccatherinetan