Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(routing): improve auto-fill of identifier #19642

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat(routing): improve auto-fill of identifier #19642

wants to merge 4 commits into from
+18 −2

Conversation

ezhil56x
Copy link
Contributor

@ezhil56x ezhil56x commented Mar 1, 2025

What does this PR do?

Visual Demo (For contributors especially)

A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).

Video Demo (if applicable):

2025-03-01.19-21-34.mp4

Image Demo (if applicable):

  • Add side-by-side screenshots of the original and updated change.
  • Highlight any significant change(s).

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

@vercel Vercel
Copy link

vercel bot commented Mar 1, 2025

@ezhil56x is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Mar 1, 2025
@graphite-app graphite-app bot requested a review from a team March 1, 2025 13:57
@algora-pbc algora-pbc bot mentioned this pull request Mar 1, 2025
Open
@github-actions github-actions bot added routing-forms area: routing forms, routing, forms ✨ feature New feature or request 💎 Bounty A bounty on Algora.io 🧹 Improvements Improvements to existing features. Mostly UX/UI labels Mar 1, 2025
@graphite-app Graphite App
Copy link

graphite-app bot commented Mar 1, 2025 •
edited
Loading

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (03/01/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (03/01/25)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (03/02/25)

1 label was added to this PR based on Keith Williams's automation.

@anikdhabal anikdhabal mentioned this pull request Mar 1, 2025
Closed
anikdhabal
anikdhabal previously approved these changes Mar 2, 2025
View reviewed changes
Copy link
Contributor

@anikdhabal anikdhabal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@anikdhabal anikdhabal enabled auto-merge (squash) March 2, 2025 06:55
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 2, 2025 •
edited
Loading

E2E results are ready!

@anikdhabal
Copy link
Contributor

@ezhil56x could you pls check why the test is failing? Pls fix it

@ezhil56x
Copy link
Contributor Author

ezhil56x commented Mar 3, 2025

Yes, I'll do it

@anikdhabal anikdhabal mentioned this pull request Mar 3, 2025
Closed
3 tasks
auto-merge was automatically disabled March 3, 2025 08:47

Head branch was pushed to by a user without write access

@ezhil56x
Copy link
Contributor Author

ezhil56x commented Mar 3, 2025

@anikdhabal I'm not sure if its breaking due to the changes I made

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anikdhabal anikdhabal anikdhabal left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
🙋 Bounty claim 💎 Bounty A bounty on Algora.io community Created by Linear-GitHub Sync ✨ feature New feature or request 🧹 Improvements Improvements to existing features. Mostly UX/UI ready-for-e2e routing-forms area: routing forms, routing, forms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CAL-5245] routing: improve auto-fill of "Identifier" with lowercase only and replace space " " with "_"
2 participants
@ezhil56x @anikdhabal