Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 19 - add n_iterations as a parameter in estimate_timecourse_params_tf() #21

Merged
merged 3 commits into from
May 29, 2024

Conversation

shackett
Copy link
Contributor

Description of your changes

  • Added an example dataset which was poorly fit by estimate_timecourse_params_tf().
    • added a test which verified that the logLik is calculated correctly. Its just super low because the optimizer is not given enough time to converge. Exposed # of iterations which along with learning rate can be used to provide room for convergence. With some minor tweaking the poorly fit curve is now fit perfectly with a modest likelihood. Closes Intercepts are not well fit if very far from zero #19

Issue ticket number and link

Type of change

  • Bug fix
  • New feature
    • Backwards Incompatible?
  • Refactoring / code clean-up
  • Documentation add / update
  • Automated Test
  • Other (please specify)

(If applicable) How has this been tested?

@shackett shackett merged commit 4daa906 into master May 29, 2024
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intercepts are not well fit if very far from zero
1 participant