Fix: Bind Extensions (#11)

* Initial commit * Bump version number and update changelog
callius · Dec 5, 2023 · a30325e · a30325e
1 parent e3caaaa
commit a30325e
Show file tree

Hide file tree

Showing 12 changed files with 51 additions and 17 deletions.
diff --git a/packages/target/CHANGELOG.md b/packages/target/CHANGELOG.md
@@ -1,3 +1,10 @@
+## 0.6.1
+
+Fixes:
+
+- Typing for `Either.bindTo`.
+- Typing for `Future<Either>.thenBind`.
+
 ## 0.6.0
 
 Features:

diff --git a/packages/target/lib/src/raise.dart b/packages/target/lib/src/raise.dart
@@ -55,7 +55,8 @@ A merge<A>(A Function(Raise<A>) block) => recover(block, id);
 Future<A> mergeAsync<A>(Future<A> Function(Raise<A>) block) =>
     recoverAsync(block, id);
 
-extension RaiseEitherExtension<Error, A> on Either<Error, A> {
+extension RaiseEitherExtension<Error, Error2 extends Error, A>
+    on Either<Error2, A> {
   /// Binds this to the given [Raise].
   ///
   /// Note: [bind] member function already exists on [Either].

diff --git a/packages/target/pubspec.yaml b/packages/target/pubspec.yaml
@@ -1,6 +1,6 @@
 name: target
 description: Functional domain modeling in Dart.
-version: 0.6.0
+version: 0.6.1
 repository: https://github.com/callius/target-dart/tree/main/packages/target
 issue_tracker: https://github.com/callius/target-dart/issues
 homepage: https://github.com/callius/target-dart

diff --git a/packages/target/test/raise_test.dart b/packages/target/test/raise_test.dart
@@ -1,6 +1,5 @@
 import 'package:dartz/dartz.dart';
-import 'package:target/src/raise.dart';
-import 'package:target/src/raise_builders.dart';
+import 'package:target/target.dart';
 import 'package:test/test.dart';
 
 void main() {
@@ -177,9 +176,10 @@ void main() {
 
   group('Either.bindTo', () {
     test('returns left when left', () async {
-      const testLeft = Left<String, Unit>('failure');
+      const testLeft =
+          Left<GenericValueFailure<Unit>, Unit>(GenericValueFailure(unit));
 
-      final result = either<String, Unit>((r) {
+      final result = either<ValueFailure<Unit>, Unit>((r) {
         testLeft.bindTo(r);
         return unit;
       });

diff --git a/packages/target_annotation/CHANGELOG.md b/packages/target_annotation/CHANGELOG.md
@@ -1,3 +1,10 @@
+## 0.6.1
+
+Fixes:
+
+- Typing for `Either.bindTo`.
+- Typing for `Future<Either>.thenBind`.
+
 ## 0.6.0
 
 Features:

diff --git a/packages/target_annotation/pubspec.yaml b/packages/target_annotation/pubspec.yaml
@@ -1,6 +1,6 @@
 name: target_annotation
 description: Functional domain modeling in Dart.
-version: 0.6.0
+version: 0.6.1
 repository: https://github.com/callius/target-dart/tree/main/packages/target_annotation
 issue_tracker: https://github.com/callius/target-dart/issues
 homepage: https://github.com/callius/target-dart

diff --git a/packages/target_annotation_processor/CHANGELOG.md b/packages/target_annotation_processor/CHANGELOG.md
@@ -1,3 +1,10 @@
+## 0.6.1
+
+Fixes:
+
+- Typing for `Either.bindTo`.
+- Typing for `Future<Either>.thenBind`.
+
 ## 0.6.0
 
 Features:

diff --git a/packages/target_annotation_processor/pubspec.yaml b/packages/target_annotation_processor/pubspec.yaml
@@ -1,6 +1,6 @@
 name: target_annotation_processor
 description: Functional domain modeling in Dart.
-version: 0.6.0
+version: 0.6.1
 repository: https://github.com/callius/target-dart/tree/main/packages/target_annotation_processor
 issue_tracker: https://github.com/callius/target-dart/issues
 homepage: https://github.com/callius/target-dart
@@ -21,17 +21,17 @@ dependencies:
     git:
       url: https://github.com/callius/target-dart
       path: packages/target
-      ref: v0.6.0
+      ref: v0.6.1
   target_annotation:
     git:
       url: https://github.com/callius/target-dart
       path: packages/target_annotation
-      ref: v0.6.0
+      ref: v0.6.1
   target_extension:
     git:
       url: https://github.com/callius/target-dart
       path: packages/target_extension
-      ref: v0.6.0
+      ref: v0.6.1
 
 dev_dependencies:
   build_runner: null

diff --git a/packages/target_extension/CHANGELOG.md b/packages/target_extension/CHANGELOG.md
@@ -1,3 +1,10 @@
+## 0.6.1
+
+Fixes:
+
+- Typing for `Either.bindTo`.
+- Typing for `Future<Either>.thenBind`.
+
 ## 0.6.0
 
 Features:

diff --git a/packages/target_extension/lib/src/target_either_extensions.dart b/packages/target_extension/lib/src/target_either_extensions.dart
@@ -104,8 +104,11 @@ extension TargetFutureEitherX<L, R> on Future<Either<L, R>> {
   Future<Either<L2, R>> thenLeftMap<L2>(L2 Function(L l) f) {
     return then((it) => it.leftMap(f));
   }
+}
 
-  Future<R> thenBind(Raise<L> r) {
+extension TargetFutureEitherBindX<Error, L extends Error, R>
+    on Future<Either<L, R>> {
+  Future<R> thenBind(Raise<Error> r) {
     return then(r.bind);
   }
 }
diff --git a/packages/target_extension/pubspec.yaml b/packages/target_extension/pubspec.yaml
@@ -1,6 +1,6 @@
 name: target_extension
 description: Extensions for functional domain modeling in Dart.
-version: 0.6.0
+version: 0.6.1
 repository: https://github.com/callius/target-dart/tree/main/packages/target_extension
 issue_tracker: https://github.com/callius/target-dart/issues
 homepage: https://github.com/callius/target-dart
@@ -15,7 +15,7 @@ dependencies:
     git:
       url: https://github.com/callius/target-dart
       path: packages/target
-      ref: v0.6.0
+      ref: v0.6.1
 
 dev_dependencies:
   lint: ^2.2.0

diff --git a/packages/target_extension/test/either_extensions_test.dart b/packages/target_extension/test/either_extensions_test.dart
@@ -7,10 +7,12 @@ import 'package:test/scaffolding.dart';
 void main() {
   group('Future<Either>.thenBind', () {
     test('returns left when left', () async {
-      const testLeft = Left<String, Unit>('f');
+      const testLeft =
+          Left<GenericValueFailure<Unit>, Unit>(GenericValueFailure(unit));
 
-      final result = await eitherAsync<String, Unit>(
-        (r) => Future<Either<String, Unit>>.value(testLeft).thenBind(r),
+      final result = await eitherAsync<ValueFailure<Unit>, Unit>(
+        (r) => Future<Either<GenericValueFailure<Unit>, Unit>>.value(testLeft)
+            .thenBind(r),
       );
 
       expect(result, testLeft);