-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable scroll container #51
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Singleton is not good now, I'l add also something like this:
const jump = function () {
return jumper().apply(undefined, arguments);
};
export default jump
Using this version of Jump going forward until container support is merged into main.
|
I would love to see this merged. One potential block is that
|
@callmecavs Are there any plans to merge this and support this feature? Looks like there's quite a bit of interest. |
Any reasons to hesitating about merging this PR? |
break | ||
|
||
case 'string': | ||
container = document.querySelector(options.container) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn’t it be better to look up the container going from the target
up instead of from the document
down?
container = target.closest(options.container)
It would exclude errors where the container selector would be a common class name instead of id. Also might be faster.
any updates? |
See #50