fix(android): children views were not recycled (#516)

callstack · Mar 14, 2022 · 716b3a5 · 716b3a5
1 parent c558f98
commit 716b3a5
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 4 deletions.
diff --git a/android/src/main/java/com/reactnativepagerview/FragmentAdapter.kt b/android/src/main/java/com/reactnativepagerview/FragmentAdapter.kt
@@ -73,6 +73,10 @@ class FragmentAdapter(fragmentActivity: FragmentActivity) : FragmentStateAdapter
 
   fun getReactChildCount() = childrenViews.size
 
+  fun removeAll() {
+    childrenViews.clear()
+  }
+
   fun removeReactViewAt(index: Int) {
     markDirty()
     childrenViews.removeAt(index)

diff --git a/android/src/main/java/com/reactnativepagerview/PagerViewViewManager.kt b/android/src/main/java/com/reactnativepagerview/PagerViewViewManager.kt
@@ -81,6 +81,12 @@ class PagerViewViewManager : ViewGroupManager<ViewPager2>() {
     adapter.removeReactViewAt(index)
     postNewChanges(parent)
   }
+
+  override fun removeAllViews(parent: ViewPager2) {
+    val adapter = parent.adapter as FragmentAdapter
+    adapter.removeAll();
+    postNewChanges(parent)
+  }
 
   override fun needsCustomLayoutForChildren(): Boolean {
     return true

diff --git a/lib/commonjs/LazyPagerView.js b/lib/commonjs/LazyPagerView.js
diff --git a/lib/commonjs/LazyPagerView.js.map b/lib/commonjs/LazyPagerView.js.map
diff --git a/lib/module/LazyPagerView.js b/lib/module/LazyPagerView.js
diff --git a/lib/module/LazyPagerView.js.map b/lib/module/LazyPagerView.js.map