Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: testOnly events #1741

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: testOnly events #1741

wants to merge 4 commits into from

Conversation

mdjastrzebski
Copy link
Member

@mdjastrzebski mdjastrzebski commented Jan 28, 2025

Summary

Resolves #1738

Provides support for testOnly_onXxx events to Fire Event and User Event, which together with software-mansion/react-native-gesture-handler#3357 allow for RNGH Pressable to work with RNTL.

Test plan

Addent automatic tests. Validate after RNGH PR is merged and published.

CC: @latekvo @sidferreira

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 95.12195% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.55%. Comparing base (17ccd9e) to head (53ef89d).

Files with missing lines Patch % Lines
src/event-handler.ts 94.73% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1741      +/-   ##
==========================================
+ Coverage   95.50%   95.55%   +0.04%     
==========================================
  Files          92       93       +1     
  Lines        5139     5148       +9     
  Branches      563      564       +1     
==========================================
+ Hits         4908     4919      +11     
+ Misses        231      229       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve react-native-gesture-handler::pressable handling
1 participant