Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING] chore: update minimum node version to 18 #430

Merged
merged 12 commits into from
Nov 17, 2023
Merged

Conversation

jbroma
Copy link
Member

@jbroma jbroma commented Sep 26, 2023

Summary

Update Minimum Node Version to 18

Given that Node v16 reached its End of Life (EOL) on September 11, 2023, this pull request updates various parts of our codebase to set the minimum supported Node version to 18.

Details of the Changes:

  1. GitHub Actions Workflow Update:

    • Removed Node v16 from our testing matrix in .github/workflows/test.yml.
  2. Documentation Update:

    • Updated the minimum recommended Node version in CONTRIBUTING.md.
  3. Codebase Updates:

    • Updated the Babel config target version for both packages/dev-server/babel.config.cjs and packages/repack/babel.config.js.
    • Adjusted the "engines" field in package.json for packages/dev-server, packages/init, and packages/repack to reflect the new minimum Node version.
    • Updated the Node types version in packages/dev-server/package.json and packages/repack/package.json.
  4. Code Cleanup:

    • Removed the shim for .replaceAll in packages/repack/src/shims.ts given that this is now natively supported in Node 18+. Consequently, the import statement in packages/repack/src/index.ts was also removed.

@changeset-bot
Copy link

changeset-bot bot commented Sep 26, 2023

🦋 Changeset detected

Latest commit: 3e45e39

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@callstack/repack-dev-server Major
@callstack/repack-init Major
@callstack/repack Major
testerapp Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please

@jbroma
Copy link
Member Author

jbroma commented Sep 27, 2023

This is a BREAKING CHANGE, let's hold on with merging this for a while

@jbroma jbroma changed the title chore: update minimum node version to 18 [BREAKING] chore: update minimum node version to 18 Oct 2, 2023
@jbroma jbroma changed the base branch from main to v4 November 17, 2023 10:22
@jbroma jbroma merged commit 35e7d36 into v4 Nov 17, 2023
3 checks passed
@jbroma jbroma deleted the chore/upgrade-node branch November 17, 2023 10:55
jbroma added a commit that referenced this pull request Feb 1, 2024
* chore: bump required node version to v18

* refactor(repack): remove replaceAll shim

* chore: upgrade @types/node to ^18

* chore: remove node 16 from CI test job

* chore: use node v18 in @babel/preset-env

* docs: change minimal node version to 18+

* chore: update yarn.lock

* docs: update recommended Node version in docs

* chore(repack): remove string.prototype.replaceall from dependencies

* chore: update yarn.lock

* chore: add changeset

* chore: rework changeset
jbroma added a commit that referenced this pull request Feb 29, 2024
* chore: bump required node version to v18

* refactor(repack): remove replaceAll shim

* chore: upgrade @types/node to ^18

* chore: remove node 16 from CI test job

* chore: use node v18 in @babel/preset-env

* docs: change minimal node version to 18+

* chore: update yarn.lock

* docs: update recommended Node version in docs

* chore(repack): remove string.prototype.replaceall from dependencies

* chore: update yarn.lock

* chore: add changeset

* chore: rework changeset
jbroma added a commit that referenced this pull request Apr 5, 2024
* chore: bump required node version to v18

* refactor(repack): remove replaceAll shim

* chore: upgrade @types/node to ^18

* chore: remove node 16 from CI test job

* chore: use node v18 in @babel/preset-env

* docs: change minimal node version to 18+

* chore: update yarn.lock

* docs: update recommended Node version in docs

* chore(repack): remove string.prototype.replaceall from dependencies

* chore: update yarn.lock

* chore: add changeset

* chore: rework changeset
jbroma added a commit that referenced this pull request Apr 5, 2024
* chore: bump required node version to v18

* refactor(repack): remove replaceAll shim

* chore: upgrade @types/node to ^18

* chore: remove node 16 from CI test job

* chore: use node v18 in @babel/preset-env

* docs: change minimal node version to 18+

* chore: update yarn.lock

* docs: update recommended Node version in docs

* chore(repack): remove string.prototype.replaceall from dependencies

* chore: update yarn.lock

* chore: add changeset

* chore: rework changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants