-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BREAKING] chore: update minimum node version to 18 #430
Conversation
🦋 Changeset detectedLatest commit: 3e45e39 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes please
This is a BREAKING CHANGE, let's hold on with merging this for a while |
* chore: bump required node version to v18 * refactor(repack): remove replaceAll shim * chore: upgrade @types/node to ^18 * chore: remove node 16 from CI test job * chore: use node v18 in @babel/preset-env * docs: change minimal node version to 18+ * chore: update yarn.lock * docs: update recommended Node version in docs * chore(repack): remove string.prototype.replaceall from dependencies * chore: update yarn.lock * chore: add changeset * chore: rework changeset
* chore: bump required node version to v18 * refactor(repack): remove replaceAll shim * chore: upgrade @types/node to ^18 * chore: remove node 16 from CI test job * chore: use node v18 in @babel/preset-env * docs: change minimal node version to 18+ * chore: update yarn.lock * docs: update recommended Node version in docs * chore(repack): remove string.prototype.replaceall from dependencies * chore: update yarn.lock * chore: add changeset * chore: rework changeset
* chore: bump required node version to v18 * refactor(repack): remove replaceAll shim * chore: upgrade @types/node to ^18 * chore: remove node 16 from CI test job * chore: use node v18 in @babel/preset-env * docs: change minimal node version to 18+ * chore: update yarn.lock * docs: update recommended Node version in docs * chore(repack): remove string.prototype.replaceall from dependencies * chore: update yarn.lock * chore: add changeset * chore: rework changeset
* chore: bump required node version to v18 * refactor(repack): remove replaceAll shim * chore: upgrade @types/node to ^18 * chore: remove node 16 from CI test job * chore: use node v18 in @babel/preset-env * docs: change minimal node version to 18+ * chore: update yarn.lock * docs: update recommended Node version in docs * chore(repack): remove string.prototype.replaceall from dependencies * chore: update yarn.lock * chore: add changeset * chore: rework changeset
Summary
Update Minimum Node Version to 18
Given that Node v16 reached its End of Life (EOL) on September 11, 2023, this pull request updates various parts of our codebase to set the minimum supported Node version to 18.
Details of the Changes:
GitHub Actions Workflow Update:
.github/workflows/test.yml
.Documentation Update:
CONTRIBUTING.md
.Codebase Updates:
packages/dev-server/babel.config.cjs
andpackages/repack/babel.config.js
.package.json
forpackages/dev-server
,packages/init
, andpackages/repack
to reflect the new minimum Node version.packages/dev-server/package.json
andpackages/repack/package.json
.Code Cleanup:
.replaceAll
inpackages/repack/src/shims.ts
given that this is now natively supported in Node 18+. Consequently, the import statement inpackages/repack/src/index.ts
was also removed.