You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade fastify and related packages to v4 and v4 compatible.
Migration included changing from deprecated instance.listen() variadic function to currently supported one with configuration object.
This PR also fixes an issue where dev-server was only listening on only IPv4 or IPv6. Now, when running on localhost, both interfaces are being used for listening for connections.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Cool! Can you link the issues that this upgrade resolves?
not sure there are any open issues about that, I've discovered that some time ago - many issue simply say that the Android can't find the bundle so that will indirectly help limit those kind of questions :)
* chore: upgrade fastify to v4
* refactor(dev-server): use non-deprecated version of listen
* fix(dev-server): use proper name for @fastify/sensible as a plugin dependency
* chore: upgrade fastify to v4
* refactor(dev-server): use non-deprecated version of listen
* fix(dev-server): use proper name for @fastify/sensible as a plugin dependency
* chore: upgrade fastify to v4
* refactor(dev-server): use non-deprecated version of listen
* fix(dev-server): use proper name for @fastify/sensible as a plugin dependency
* chore: upgrade fastify to v4
* refactor(dev-server): use non-deprecated version of listen
* fix(dev-server): use proper name for @fastify/sensible as a plugin dependency
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade
fastifyand related packages to v4 and v4 compatible.Migration included changing from deprecated
instance.listen()variadic function to currently supported one with configuration object.This PR also fixes an issue where
dev-serverwas only listening on only IPv4 or IPv6. Now, when running onlocalhost, both interfaces are being used for listening for connections.Test plan