Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add X-React-Native-Project-Root header #475

Merged
merged 4 commits into from
Dec 14, 2023

Conversation

szymonrybczak
Copy link
Contributor

@szymonrybczak szymonrybczak commented Dec 12, 2023

Summary

Inside React Native CLI we're looking for X-React-Native-Project-Root header, to check if bundler is already running for the project.

before / after
CleanShot 2023-12-12 at 11 45 17@2x
CleanShot 2023-12-12 at 11 45 56@2x

Test plan

Update latest CLI, or update React Native version inside packages/TesterApp and start bundler. When running run-ios command, "info A dev server is already running for this project on port 8081." should be printed to console.

Copy link

changeset-bot bot commented Dec 12, 2023

🦋 Changeset detected

Latest commit: 3af6050

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@callstack/repack-dev-server Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@jbroma jbroma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Thanks for handling this @szymonrybczak!

@jbroma jbroma merged commit cc997a2 into callstack:main Dec 14, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants