Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make webpack cache work #479

Merged
merged 3 commits into from
Dec 18, 2023
Merged

fix: make webpack cache work #479

merged 3 commits into from
Dec 18, 2023

Conversation

ambar
Copy link
Contributor

@ambar ambar commented Dec 16, 2023

Summary

See https://webpack.js.org/api/node/#run

Don't forget to close the compiler, so that low-priority work (like persistent caching) have the opportunity to complete.

turbo run build && yarn workspace testerapp run bundle:ios

# without cache
webpack 5.75.0 compiled successfully in 14680 ms 
# with cache
webpack 5.75.0 compiled successfully in 1000 ms

Test plan

Copy link

changeset-bot bot commented Dec 16, 2023

🦋 Changeset detected

Latest commit: a80e924

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
testerapp Patch
@callstack/repack Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@RafikiTiki RafikiTiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the contribution – the compiler.close was obviously missed there 🙌

@RafikiTiki RafikiTiki merged commit b1ad518 into callstack:main Dec 18, 2023
4 checks passed
@jbroma
Copy link
Member

jbroma commented Dec 18, 2023

Thank you for your contribution @ambar, great stuff 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants