New arch migration #495
Merged
New arch migration #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 985d6e5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
troZee
requested review from
RafikiTiki,
jbroma,
atlj,
krozniata and
okwasniewski
okwasniewski
reviewed
Feb 1, 2024
packages/repack/android/src/main/java/com/callstack/repack/ChunkManagerModule.kt
Outdated
Show resolved
Hide resolved
packages/repack/android/src/main/java/com/callstack/repack/ChunkManagerPackage.kt
Show resolved
Hide resolved
packages/repack/android/src/main/java/com/callstack/repack/ChunkManagerPackage.kt
Outdated
Show resolved
Hide resolved
atlj
approved these changes
Feb 1, 2024
krozniata
approved these changes
Feb 1, 2024
okwasniewski
approved these changes
Feb 1, 2024
jbroma
force-pushed
the
troZee/new-arch-migration
branch
from
c8b0e46 to
985d6e5
Compare
jbroma
approved these changes
Feb 1, 2024
This was referenced Feb 1, 2024
jbroma
added a commit
that referenced
this pull request
Feb 29, 2024
* TS spec + android old arch * android new arch * ios support * fix tests * change needsEagerInit to true * add early return * fix comment * chore: add changeset --------- Co-authored-by: Piotr Trocki <[email protected]> Co-authored-by: Jakub Romanczyk <[email protected]>
jbroma
added a commit
that referenced
this pull request
Apr 5, 2024
* TS spec + android old arch * android new arch * ios support * fix tests * change needsEagerInit to true * add early return * fix comment * chore: add changeset --------- Co-authored-by: Piotr Trocki <[email protected]> Co-authored-by: Jakub Romanczyk <[email protected]>
jbroma
added a commit
that referenced
this pull request
Apr 5, 2024
* TS spec + android old arch * android new arch * ios support * fix tests * change needsEagerInit to true * add early return * fix comment * chore: add changeset --------- Co-authored-by: Piotr Trocki <[email protected]> Co-authored-by: Jakub Romanczyk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims to add a turbo module with backward compatibility. Re.Pack current implementation directly uses RN native modules, but with this change, there is a
SPECimplementation that allows for more efficient communication between native and JavaScript. This change allows for both old and new architecture. All implementation follows the official react native bob builder template.Test plan
RN>=0.68.0NOTE: TesterApp currently meets this requirement if you're using repack TesterApp.
For Android
You will only need to update your
android/gradle.propertiesfile as follows:newArchEnabled=trueand then
yarn TesterApp:startFor iOS
Run pod install with the flags:
RCT_NEW_ARCH_ENABLED=1 pod installand then
yarn TesterApp:start