Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove duplicated React-Core dependency from podspec #496

Merged
merged 2 commits into from
Feb 2, 2024
Merged

fix: remove duplicated React-Core dependency from podspec #496

merged 2 commits into from
Feb 2, 2024

Conversation

krozniata
Copy link
Member

Summary

This small PR removes duplicated React-Core dependency from .podspec file.

It is included either in install_modules_dependencies function or in L28

Test plan

Make sure that TesterApp builds and runs successfully on both architectures

Copy link

changeset-bot bot commented Feb 2, 2024

🦋 Changeset detected

Latest commit: b1dbbdb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@callstack/repack Patch
testerapp Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jbroma jbroma merged commit 4da4008 into callstack:v4 Feb 2, 2024
3 checks passed
@jbroma
Copy link
Member

jbroma commented Feb 2, 2024

Nice find, thanks @krozniata 🎉

jbroma pushed a commit that referenced this pull request Feb 29, 2024
* fix: remove duplicated React-Core dependency from podspec

* chore: add changeset
jbroma pushed a commit that referenced this pull request Apr 5, 2024
* fix: remove duplicated React-Core dependency from podspec

* chore: add changeset
jbroma pushed a commit that referenced this pull request Apr 5, 2024
* fix: remove duplicated React-Core dependency from podspec

* chore: add changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants