fix: support non-classic paths to HMRClient from react-native #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4b0a9f7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
RafikiTiki
approved these changes
Feb 9, 2024
jbroma
added a commit
that referenced
this pull request
Feb 29, 2024
jbroma
added a commit
that referenced
this pull request
Apr 5, 2024
jbroma
added a commit
that referenced
this pull request
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When using
pnpmoryarnwithpnpmlinker, the path toreact-nativecan be different:yarn (with pnpm linker):
react-native-virtual-38652004f3/package/Libraries/Utilities/HMRClient.jspnpm:
[email protected]_@[email protected]_@[email protected][email protected]/node_modules/react-native/Libraries/Utilities/HMRClient.jsThis change allows to match these additional cases as well and include
DevServerClientfrom 'Re.Pack' properly.Pretty sure we don't need to make it any more stricter than this, the chance of collision with something else is close to 0
Test plan