refactor(repack): use done hook inside of OutputPlugin
#515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b815dc0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jbroma
changed the title
done hook inside of OutputPlugindone hook inside of OutputPlugin
RafikiTiki
reviewed
Mar 6, 2024
|
one thing of note: there are few cases in this PR where I was forced to use non-null assertion operator, but newest webpack 5.90.3 introduced some improved typings for |
jbroma
added a commit
that referenced
this pull request
Apr 5, 2024
* move output path check to the beginning * feat: move final phase to done hook * feat: use sourcemap file directly instead of extracting from compilation * refactor: move chunk classifying to done hook * refactor: finish migration to done hook * fix: tests & typescript issues * chore: add changeset * refactor: rename chunks to statsChunkMap
jbroma
added a commit
that referenced
this pull request
Apr 5, 2024
* move output path check to the beginning * feat: move final phase to done hook * feat: use sourcemap file directly instead of extracting from compilation * refactor: move chunk classifying to done hook * refactor: finish migration to done hook * fix: tests & typescript issues * chore: add changeset * refactor: rename chunks to statsChunkMap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrated
OutputPluginto run only inside ofdonehook - this enables usage ofOutputPluginwithrspackas previous approach utilised features not available inrspackyet(?)Test plan