Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relay call node definitions. #396

Merged
merged 11 commits into from
Feb 19, 2021
Merged

Relay call node definitions. #396

merged 11 commits into from
Feb 19, 2021

Conversation

cgyurgyik
Copy link
Collaborator

@cgyurgyik cgyurgyik commented Feb 9, 2021

This is a more careful approach to writing the Dahlia definitions of the Relay call nodes, as well as a frontend generation and correctness test for each.

@cgyurgyik cgyurgyik added the C: Relay Relay-to-FuTIL compiler label Feb 9, 2021
@cgyurgyik cgyurgyik marked this pull request as ready for review February 15, 2021 18:43
@cgyurgyik
Copy link
Collaborator Author

This includes everything except a std_exp definition/declaration for nn.softmax. Currently, there is a test for softmax (frontend and correctness) without an expect.

I think this should be sufficient enough for review.

@rachitnigam
Copy link
Contributor

What's the reason to have a test without the expect file?

@cgyurgyik
Copy link
Collaborator Author

What's the reason to have a test without the expect file?

Simplicity of just adding the .expect when std_exp is complete. I can remove it if you'd like, makes no difference to me.

@cgyurgyik cgyurgyik changed the title [WIP] Relay call node definitions. Relay call node definitions. Feb 19, 2021
@rachitnigam rachitnigam merged commit 3fafe12 into master Feb 19, 2021
@rachitnigam rachitnigam deleted the relay-tests branch February 19, 2021 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Relay Relay-to-FuTIL compiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants