Fix Safe Links policy-to-rule matching #325
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ORCA was failing on check 113 (Do not let users click through safe links to original URL), but the online Configuration Analyzer wasn't showing an issue. While looking into that issue, I noticed that ORCA said our custom Safe Links policy Does not apply. This PR resolves the issue for me, but I don't know about the ramifications for the rest of the package. PTAL
The underlying issue is that our custom Safe Links policy and rule don't always have the same name (similar to the Preset policies, according to your code comments). Not sure how we got into that situation.
Context: