Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collating seqkit statistics files into a single file #16

Merged
merged 5 commits into from
Sep 15, 2023

Conversation

y-popov
Copy link
Collaborator

@y-popov y-popov commented Aug 25, 2023

@y-popov
Copy link
Collaborator Author

y-popov commented Aug 25, 2023

There are two topics to discuss

  1. Currently code uses meta.id as sample ID. This value changes between stages. Shoud we use another source of sample ID?
  2. Pipeline outputs resulting file into params.outdir. Do we want to change this as well as a filename?

@vaofford
Copy link
Collaborator

There are two topics to discuss

  1. Currently code uses meta.id as sample ID. This value changes between stages. Shoud we use another source of sample ID?
  2. Pipeline outputs resulting file into params.outdir. Do we want to change this as well as a filename?
  1. Interesting - agree, there should be a consistent reference for the sample ID are we able to map out what each process is using to get the sample ID to look at the best place to source it consistently?
  2. Should be OK to go into the same directory - in addition, we'd want to start moving to a production mode where we don't publish the intermediate/individual files

@vaofford
Copy link
Collaborator

Added small tweak to write the collated seqkit stats file to the seqkit_stats subdirectory. If you're happy with that, all tests ran ok and we can merge?

@y-popov
Copy link
Collaborator Author

y-popov commented Sep 15, 2023

Yeap, I am. Seems we are ready to merge this

@vaofford vaofford merged commit d8242bd into develop Sep 15, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants