Updating can-define/map documentation #382

codepen
ES6
Better elaboration that it doesn't delete the keys predefined by type because it would also have to delete those getter and setters on other instances. -- improved

map/map.prototype.forEach.html

Needs:

codepen
ES6
Syntax Highlighting

Discourse:

While this has a Use section it should probably elaborate further what the example is actually doing. -- improved

map/map.prototype.get.html

Needs:

codepen
ES6

map/map.prototype.serialize.html

Needs:

codepen
ES6

map/map.prototype.set.html

Needs:

Examples

map/map.prototype.update.html

Needs:

codepen
ES6

map/map.prototype.updateDeep.html

Needs:

codepen
ES6

map/map.prototype.wildcard.html

Needs:

Syntax Highlighting
ES6

…s when deleteKey is called on a pre-defined property.

… the Use section focused on returning false. Moved the initial example to the signature.

…p/KeysEvent.html stating that events.keys.md is a stub.

…ection, though it might be suggested to change them to separate signatures.

justinbmeyer · 2018-09-02T19:02:54Z

map/docs/define-map.md

 } );
 ```
+<!-- @codepen -->


make sure to note this in the PR.

justinbmeyer · 2018-09-02T19:50:13Z

map/docs/events.keys.md


+  const person = new DefineMap({name: "Justin"});
+
+  list.on("can.keys", (event) => {


List is undefined, please make sure to run all examples.

justinbmeyer · 2018-09-02T20:30:35Z

Seal is checked off, but there was no codepen:

same with wildcard.

…-mapCodepen

…into 370-mapCodepen

…st/list.

indifferentghost added 18 commits August 28, 2018 17:23

updated example to es6 to prototype.assign.md

ec75ae4

Updated example to ES6 syntax. Added link to codepen.

6b9371d

Updated examples, Added a use section hoping to elaborate what happen…

a70a63e

…s when deleteKey is called on a pre-defined property.

Updated to ES6 syntax. Made codepen-able. Added some documentation to…

c84c78c

… the Use section focused on returning false. Moved the initial example to the signature.

Updated syntax and and added codepen link.

50593d4

updated to ES6. It now links to codepen.

497bf82

updateDeep is ES6. It now links to codepen.

cc0dbc6

Changed from single to double quote to match other examples.

925b9ba

added codepen example to the non deprecated use of set.

09f24ef

get has es6 codepenable examples.

fc1794d

Syntax, ES6 and link to codepen added. Commented on issue #378 for ma…

0a69749

…p/KeysEvent.html stating that events.keys.md is a stub.

updated events.keys.md spacing

a19484d

events.propertyName.md updated example.

05ea58e

updated syntax and linked to codepen. Also threw them down to a use s…

c3dbf93

…ection, though it might be suggested to change them to separate signatures.

fixed spacing error in static.extend.md

b5e9b11

major updates to define-map.md documentation.

50b319c

added syntax highlighting and updated to es6 syntax for wildcard.

c92a6e4

working es6 codepen-able example on static.seal.md

d37f13e

justinbmeyer reviewed Sep 2, 2018

View reviewed changes

map/docs/define-map.md Outdated

} );

```



Copy link

Contributor

justinbmeyer Sep 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure to note this in the PR.

minor cleanup

5fbd6f5

justinbmeyer reviewed Sep 2, 2018

View reviewed changes

justinbmeyer and others added 7 commits September 3, 2018 09:58

some additional fixes

1f45e6f

use any now for accepting any type

f805d9a

Merge branch 'master' of https://github.com/canjs/can-define into 370…

b71e7d6

…-mapCodepen

Merge branch '370-mapCodepen' of https://github.com/canjs/can-define …

0b20692

…into 370-mapCodepen

updated assign and assignDeep to more mirror their counterparts in li…

0ea7a52

…st/list.

codepen updates across map.

a4b8c5b

Updated and fixed spelling errors.

879b73c

indifferentghost merged commit 95f4739 into master Sep 4, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updating can-define/map documentation #382

Updating can-define/map documentation #382

indifferentghost commented Aug 31, 2018

justinbmeyer Sep 2, 2018

justinbmeyer Sep 2, 2018

justinbmeyer commented Sep 2, 2018 •

edited

Loading


		const person = new DefineMap({name: "Justin"});

		list.on("can.keys", (event) => {

Updating can-define/map documentation #382

Updating can-define/map documentation #382

Conversation

indifferentghost commented Aug 31, 2018

Needs:

Needs:

Needs:

Needs:

Needs:

Needs:

Needs:

Discourse:

Needs:

Needs:

Needs:

Needs:

Needs:

Needs:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

justinbmeyer commented Sep 2, 2018 • edited Loading

justinbmeyer commented Sep 2, 2018 •

edited

Loading