-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use k8s_service_info lib instead of SDI #87
Conversation
ea87584
to
e425c8d
Compare
Use the k8s_service_info for receiving the MLMD GRPC Service info instead of using the SDI, as it will stop being supported soon. Fixes #76
e425c8d
to
a2fb053
Compare
Created canonical/charmed-kubeflow-chisme#94 to capture the discussion about how we could reuse code like the Component here that needs a charm library |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tiny issue otherwise lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving since the last comment @ca-scribner had is resolved now.
Thanks @orfeas-k ! It looks like @ca-scribner has to approve it as he requested changes ;( |
Dismissing @ca-scribner as the change he requested was very small and I did the change. Thanks both for the reviews! |
The request was to change a duplicated line, which I did. This is a small enough change to not require another review.
👍 ty! |
Use the k8s_service_info for receiving the MLMD GRPC Service info instead of using the SDI, as it will stop being supported soon.
Fixes #76
NOTE for reviewers:
Testing instructions
mlmd
fromchannel latest/edge
withtrust
Test upgrade path
Because this charm was recently refactored from podspec to sidecar pattern, there will no be a migration from its previous stable version.