cli/get_repo_info: suppress importlib.path deprecation warning #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xmkg
force-pushed
the
enhancement/suppress-importlib-deprecation-warning
branch
2 times, most recently
from
45368e4
to
da95871
Compare
xmkg
force-pushed
the
enhancement/suppress-importlib-deprecation-warning
branch
from
da95871
to
9d622e1
Compare
we're aware that the importlib.path is being deprecated but we still want to support python 3.8, which does not have the `as_file` function. so, this patch suppresses the annoying deprecation warning. also noticed that when the resources.path() used in a with clause, it raises an exception when the file is not present in Python 3.8.10, which is the latest python 3.8 version in Focal at the moment. Therefore, used contextlib.suppress(Exception) to deal with that as well. Relevant past MP's: canonical#864, canonical#854 Signed-off-by: Mustafa Kemal Gilor <[email protected]>
xmkg
force-pushed
the
enhancement/suppress-importlib-deprecation-warning
branch
from
9d622e1
to
5ebcd2b
Compare
|
@dosaboy rebased this one, should be trivial enough to land. |
nicolasbock
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we're aware that the importlib.path is being deprecated but we still want to support python 3.8, which does not have the
as_filefunction.also noticed that when the resources.path() used in a with clause, it raises an exception when the file is not present in Python 3.8.10, which is the latest python 3.8 version in Focal at the moment. Therefore, used contextlib.suppress(Exception) to deal with that as well.
Relevant past MP's: #864, #854