Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use k8s_service_info lib instead of SDI #436

Merged
merged 9 commits into from
Apr 24, 2024
Merged

refactor: use k8s_service_info lib instead of SDI #436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
87e814c
refactor: use k8s_service_info lib instead of SDI
DnPlas Apr 17, 2024
62af86b
debug: remove destructive mode
DnPlas Apr 17, 2024
d5ee17b
skip: update based on feedback
DnPlas Apr 18, 2024
de7ace1
skip: rename component and update based on feedback
DnPlas Apr 19, 2024
3d74efd
skip: remove comment
DnPlas Apr 19, 2024
f344636
debug: remove destructive mode for debugging purposes
DnPlas Apr 22, 2024
7ca431f
revert prev commit
DnPlas Apr 22, 2024
be1c887
Merge branch 'dnplas-dev-branch-fix-ci' into KF-5485-use-k8s-service-…
DnPlas Apr 22, 2024
ef7f68d
Merge branch 'dnplas-dev-branch-fix-ci' into KF-5485-use-k8s-service-…
DnPlas Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions charms/kfp-metadata-writer/charmcraft.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Learn more about charmcraft.yaml configuration at:
# https://juju.is/docs/sdk/charmcraft-config
type: "charm"
# Copyright 2024 Canonical Ltd.
# See LICENSE file for licensing details.

type: charm
bases:
- build-on:
- name: "ubuntu"
Expand All @@ -10,8 +11,12 @@ bases:
channel: "20.04"
parts:
charm:
# These build-packages are defined here because pydantic needs them
# at build time. As long as pydantic is listed in requirements.in, this
# list cannot be removed/changed.
build-packages: [cargo, rustc, pkg-config, libffi-dev, libssl-dev]
charm-python-packages: [setuptools, pip] # Fixes install of some packages
# Install jinja2 (a dependency of charmed-kubeflow-chisme) from binary to avoid build-time issues
# See https://github.com/canonical/bundle-kubeflow/issues/883
# Remove when https://github.com/canonical/charmcraft/issues/1664 is fixed
charm-binary-python-packages: [jinja2]
charm-binary-python-packages: [jinja2]
Loading
Loading