Skip to content

Commit

Permalink
client/lxd_projects: avoid fmt.Sprintf() as it is slow
Browse files Browse the repository at this point in the history
Signed-off-by: Simon Deziel <[email protected]>
  • Loading branch information
simondeziel committed Jan 31, 2025
1 parent 5bf1faf commit 009780d
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions client/lxd_projects.go
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package lxd

import (
"fmt"
"net/url"

"github.com/canonical/lxd/shared/api"
Expand Down Expand Up @@ -56,7 +55,7 @@ func (r *ProtocolLXD) GetProject(name string) (*api.Project, string, error) {
project := api.Project{}

// Fetch the raw value
etag, err := r.queryStruct("GET", fmt.Sprintf("/projects/%s", url.PathEscape(name)), nil, "", &project)
etag, err := r.queryStruct("GET", "/projects/"+url.PathEscape(name), nil, "", &project)
if err != nil {
return nil, "", err
}
Expand All @@ -74,7 +73,7 @@ func (r *ProtocolLXD) GetProjectState(name string) (*api.ProjectState, error) {
projectState := api.ProjectState{}

// Fetch the raw value
_, err = r.queryStruct("GET", fmt.Sprintf("/projects/%s/state", url.PathEscape(name)), nil, "", &projectState)
_, err = r.queryStruct("GET", "/projects/"+url.PathEscape(name)+"/state", nil, "", &projectState)
if err != nil {
return nil, err
}
Expand Down Expand Up @@ -106,7 +105,7 @@ func (r *ProtocolLXD) UpdateProject(name string, project api.ProjectPut, ETag st
}

// Send the request
_, _, err = r.query("PUT", fmt.Sprintf("/projects/%s", url.PathEscape(name)), project, ETag)
_, _, err = r.query("PUT", "/projects/"+url.PathEscape(name), project, ETag)
if err != nil {
return err
}
Expand All @@ -122,7 +121,7 @@ func (r *ProtocolLXD) RenameProject(name string, project api.ProjectPost) (Opera
}

// Send the request
op, _, err := r.queryOperation("POST", fmt.Sprintf("/projects/%s", url.PathEscape(name)), project, "", true)
op, _, err := r.queryOperation("POST", "/projects/"+url.PathEscape(name), project, "", true)
if err != nil {
return nil, err
}
Expand All @@ -138,7 +137,7 @@ func (r *ProtocolLXD) DeleteProject(name string) error {
}

// Send the request
_, _, err = r.query("DELETE", fmt.Sprintf("/projects/%s", url.PathEscape(name)), nil, "")
_, _, err = r.query("DELETE", "/projects/"+url.PathEscape(name), nil, "")
if err != nil {
return err
}
Expand Down

0 comments on commit 009780d

Please sign in to comment.