Safer path operations #14490
Open
Safer path operations #14490
+30
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Deziel <[email protected]>
This protects against malicious use of `..` in path elements being joined resulting in accessing files/directories outside of the expected parent dir. Signed-off-by: Simon Deziel <[email protected]>
`fmt.Sprintf` being much slower it should be kept for when it is really needed. It's slowness comes from using reflection under the hood making it the slowest of the `fmt.Sprint*` functions. Signed-off-by: Simon Deziel <[email protected]>
simondeziel
force-pushed
the
safer-path-operations
branch
from
90b0281
to
c939bec
Compare
kadinsayani
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tentatively addresses https://github.com/canonical/lxd/security/code-scanning?query=path%3Alxd%2Finstance_logs.go+is%3Aopen+branch%3Amain+