auth: Add entitlements to LXD entities (part 2: Enrich LXD resources with entitlements) #14748
+916
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Documentation
gabrielmougard
force-pushed
the
feat/auth-dry-run-check-part3
branch
11 times, most recently
from
d5f0001 to
3cae833
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
gabrielmougard
force-pushed
the
feat/auth-dry-run-check-part3
branch
2 times, most recently
from
e653ad9 to
7f5457a
Compare
gabrielmougard
force-pushed
the
feat/auth-dry-run-check-part3
branch
2 times, most recently
from
171b326 to
1a09849
Compare
minaelee
reviewed
Jan 10, 2025
gabrielmougard
force-pushed
the
feat/auth-dry-run-check-part3
branch
from
1a09849 to
e18b874
Compare
|
@minaelee thanks for the feedbacks. Fixing that right now |
gabrielmougard
force-pushed
the
feat/auth-dry-run-check-part3
branch
4 times, most recently
from
6f763e7 to
c793358
Compare
edlerd
reviewed
Jan 10, 2025
This interface will need to be implemented for each API types that need to be returned from the API handlers with `access_entitlements` Signed-off-by: Gabriel Mougard <[email protected]> Co-authored-by: Mark Laing <[email protected]>
…es that are eligible for entitlement enrichment Signed-off-by: Gabriel Mougard <[email protected]> Co-authored-by: Mark Laing <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]> Co-authored-by: Mark Laing <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]> Co-authored-by: Mark Laing <[email protected]>
This function add entitlements to a map of entity URLs to EntitlementReporters, which are in practice API types implementing the `ReportEntitlements` method. Signed-off-by: Gabriel Mougard <[email protected]> Co-authored-by: Mark Laing <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]>
gabrielmougard
force-pushed
the
feat/auth-dry-run-check-part3
branch
from
eebe53d to
53c6a8e
Compare
|
@markylaing updated following the approach you suggested this morning. I also added the enrichment for all the other entities. |
Signed-off-by: Gabriel Mougard <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]>
…-group' entities Signed-off-by: Gabriel Mougard <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]>
…entitlements' fields Signed-off-by: Gabriel Mougard <[email protected]>
gabrielmougard
force-pushed
the
feat/auth-dry-run-check-part3
branch
from
53c6a8e to
01a6872
Compare
edlerd
approved these changes
Jan 24, 2025
| return response.SmartError(err) | ||
| } | ||
|
|
||
| if len(withEntitlements) > 0 && recursion != "1" { |
There was a problem hiding this comment.
Suggested change
| if len(withEntitlements) > 0 && recursion != "1" { | |
| if len(withEntitlements) > 0 && !recursion { |
Should be more future-proof this way in case higher recursion levels are introduced. wdyt?
| return response.SmartError(err) | ||
| } | ||
|
|
||
| if len(withEntitlements) > 0 && recursion != "1" { |
There was a problem hiding this comment.
Similar to above, there are a couple of more occurrences like this below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second part of a group of three stacked PRs.
IsFineGrainedfield) #14745