[Backport 1.28-strict] CI: Fix addons CI (#4913)(#4923) #4932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the "Test core addons" job fails because the test_cis test fails, having 2 more warnings than expected. Those warnings are from ``microk8s kube-burner``, which has the following new warnings (the checks were passing before): ``` [WARN] 2.3 Ensure that the --auto-tls argument is not set to true (Automated) [WARN] 2.6 Ensure that the --peer-auto-tls argument is not set to true (Automated) `` Those warnings appear because the commands used for checking them fail: ``` 2.3 audit test did not run: failed to run: "/bin/ps -ef | /bin/grep k8s-dqlite | /bin/grep -v grep", output: "", error: exit status 1 2.6 audit test did not run: failed to run: "/bin/ps -ef | /bin/grep k8s-dqlite | /bin/grep -v grep", output: "", error: exit status 1 ``` Those errors would suggest that there is no ``k8s-dqlite`` process running on the node... but it should. In ``test_cis``, after enabling ``cis-hardening`` (``microk8s enable cis-hardening``) and before running ``microk8s kube-burner``, in the test we're waiting for Kubernetes to be available, accesible, and ready (``wait_for_installation``), which would only be possible if ``k8s-dqlite`` would be running. What's more, this issue does not occur when manually running the exact same commands as in the GitHub action, even on the same GitHub Runners. Pinning pytest to 8.3.4 seems to be solving the issue above (8.3.5 was released a few days ago).
berkayoz
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the addons-CI by changing the distro in the test and pinning pytest. For further info please refer to the back-ported PRs.