cgroups: fall back to parent cgroup if no child found #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a change in snapd 2.65+, not all snap apps get a child cgroup any more.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #152 +/- ##
==========================================
+ Coverage 68.37% 68.90% +0.52%
==========================================
Files 16 16
Lines 876 878 +2
Branches 126 89 -37
==========================================
+ Hits 599 605 +6
+ Misses 251 250 -1
+ Partials 26 23 -3 ☔ View full report in Codecov by Sentry. |
|
OK no. This is wrong, 'innit. It just shows that we're not getting a cgroup around the snapped app… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a change in snapd 2.65+, not all snap apps get a child cgroup any more.