Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: be verbose when installing snaps #155

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Conversation

Saviq
Copy link
Collaborator

@Saviq Saviq commented Nov 19, 2024

Otherwise things might look like they're hanging.


To test:

snap install mir-test-tools
snap remove ubuntu-frame
pytest -vsk "frame and asciinema" --deps
# you'll see the install progress
pytest -vsk "tools and asciinema" --deps
# you'll just see a message that it's already installed

@Saviq Saviq requested a review from a team as a code owner November 19, 2024 16:44
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 18.75000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 68.21%. Comparing base (9ebe15c) to head (95958fe).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
mir-ci/mir_ci/conftest.py 18.75% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #155      +/-   ##
==========================================
- Coverage   68.49%   68.21%   -0.29%     
==========================================
  Files          16       16              
  Lines         876      884       +8     
  Branches       89       93       +4     
==========================================
+ Hits          600      603       +3     
- Misses        251      256       +5     
  Partials       25       25              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Saviq Saviq force-pushed the verbose-snap-wait branch from a526aca to 6b5bcae Compare November 19, 2024 16:59
Copy link

@Hook25 Hook25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should solve the output timeout issue. +1 from me

@Saviq Saviq force-pushed the verbose-snap-wait branch from 526946e to 4017520 Compare December 4, 2024 14:57
@Saviq Saviq requested a review from tarek-y-ismail December 4, 2024 15:13
@Saviq Saviq force-pushed the verbose-snap-wait branch 3 times, most recently from 694a4f1 to 5d58f0b Compare December 5, 2024 14:44
Otherwise things might look like they're hanging.
@Saviq Saviq force-pushed the verbose-snap-wait branch from 5d58f0b to 95958fe Compare December 9, 2024 09:35
@Saviq Saviq changed the base branch from main to fix-ci-assets December 9, 2024 09:35
Base automatically changed from fix-ci-assets to main December 9, 2024 14:15
@tarek-y-ismail tarek-y-ismail added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit 87fac76 Dec 11, 2024
18 of 20 checks passed
@tarek-y-ismail tarek-y-ismail deleted the verbose-snap-wait branch December 11, 2024 16:53
Saviq added a commit to canonical/checkbox-mir that referenced this pull request Dec 11, 2024
Fix ci assets (canonical/mir-ci#156)
wayland: crop the timestamp so it fits in `uint` (canonical/mir-ci#157)
deps: be verbose when installing snaps (canonical/mir-ci#155)
Saviq pushed a commit that referenced this pull request Jan 10, 2025
Otherwise things might look like they're hanging.

---

To test:
```
snap install mir-test-tools
snap remove ubuntu-frame
pytest -vsk "frame and asciinema" --deps
# you'll see the install progress
pytest -vsk "tools and asciinema" --deps
# you'll just see a message that it's already installed
```
Saviq added a commit to canonical/checkbox-mir that referenced this pull request Jan 10, 2025
Fix ci assets (canonical/mir-ci#156)
wayland: crop the timestamp so it fits in `uint` (canonical/mir-ci#157)
deps: be verbose when installing snaps (canonical/mir-ci#155)
Saviq pushed a commit that referenced this pull request Jan 10, 2025
Otherwise things might look like they're hanging.

---

To test:
```
snap install mir-test-tools
snap remove ubuntu-frame
pytest -vsk "frame and asciinema" --deps
# you'll see the install progress
pytest -vsk "tools and asciinema" --deps
# you'll just see a message that it's already installed
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants