Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for updating the display configuration while the server is running #59

Merged
merged 28 commits into from
Nov 2, 2023

Conversation

mattkae
Copy link
Contributor

@mattkae mattkae commented Oct 19, 2023

What's new?

  • Added a single test for updating the display configuration while a display server is running
  • This does not work with ubuntu frame or mir-kiosk as they don't respect the environment variable
  • We can add more tests if you think this is a viable route 👍

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #59 (18d4c2c) into main (73e6880) will increase coverage by 0.88%.
Report is 1 commits behind head on main.
The diff coverage is 86.95%.

@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
+ Coverage   63.41%   64.29%   +0.88%     
==========================================
  Files          10       11       +1     
  Lines         697      717      +20     
  Branches       85       87       +2     
==========================================
+ Hits          442      461      +19     
  Misses        233      233              
- Partials       22       23       +1     
Files Coverage Δ
mir-ci/mir_ci/display_server.py 78.12% <100.00%> (+0.70%) ⬆️
mir-ci/mir_ci/output_watcher.py 83.33% <83.33%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@Saviq Saviq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tweaks inline

mir-ci/mir_ci/display_server.py Outdated Show resolved Hide resolved
mir-ci/mir_ci/output_watcher.py Outdated Show resolved Hide resolved
mir-ci/mir_ci/test_display_configuration.py Outdated Show resolved Hide resolved
mir-ci/mir_ci/test_display_configuration.py Outdated Show resolved Hide resolved
@Saviq Saviq force-pushed the feature/display_configuration branch from f68327a to a85e7b4 Compare October 23, 2023 18:00
@Saviq Saviq force-pushed the feature/display_configuration branch from a85e7b4 to ad14a80 Compare October 23, 2023 18:15
@mattkae mattkae requested a review from Saviq October 23, 2023 21:34
Copy link
Contributor

@AlanGriffiths AlanGriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need more tests like this

Copy link
Collaborator

@Saviq Saviq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why you needed the decorator on each test rather than the class, but OK :)

@Saviq Saviq added this pull request to the merge queue Nov 2, 2023
Merged via the queue into main with commit 4e9b6ee Nov 2, 2023
@Saviq Saviq deleted the feature/display_configuration branch November 2, 2023 12:29
Saviq added a commit that referenced this pull request Mar 19, 2024
Tests for updating the display configuration while the server is running
Saviq added a commit that referenced this pull request Jan 10, 2025
Tests for updating the display configuration while the server is running
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants