-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests for updating the display configuration while the server is running #59
Conversation
…mir-ci into feature/display_configuration
…mir-ci into feature/display_configuration
Codecov Report
@@ Coverage Diff @@
## main #59 +/- ##
==========================================
+ Coverage 63.41% 64.29% +0.88%
==========================================
Files 10 11 +1
Lines 697 717 +20
Branches 85 87 +2
==========================================
+ Hits 442 461 +19
Misses 233 233
- Partials 22 23 +1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
We want it to be a dep of the test.
Otherwise things get confused and the test runs in `--deps`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some tweaks inline
f68327a
to
a85e7b4
Compare
a85e7b4
to
ad14a80
Compare
…mir-ci into feature/display_configuration
…mir-ci into feature/display_configuration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need more tests like this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why you needed the decorator on each test rather than the class, but OK :)
Tests for updating the display configuration while the server is running
Tests for updating the display configuration while the server is running
What's new?