Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snaps: skip usns for base: core24 snaps #70

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Conversation

Saviq
Copy link
Collaborator

@Saviq Saviq commented Feb 6, 2024

The security DB doesn't yet have noble.

@Saviq Saviq requested a review from AlanGriffiths February 6, 2024 12:41
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@183a1a0). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #70   +/-   ##
=======================================
  Coverage        ?   64.64%           
=======================================
  Files           ?       11           
  Lines           ?      724           
  Branches        ?       88           
=======================================
  Hits            ?      468           
  Misses          ?      233           
  Partials        ?       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The security DB doesn't yet have `noble`.
Copy link
Contributor

@AlanGriffiths AlanGriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The skip USNs bit looks fine. I'm not quite sure of the process_snaps bit, but what could go wrong anyway?

@AlanGriffiths AlanGriffiths added this pull request to the merge queue Feb 6, 2024
Merged via the queue into main with commit 2980bda Feb 6, 2024
11 checks passed
@AlanGriffiths AlanGriffiths deleted the skip-noble-usns branch February 6, 2024 15:01
Saviq pushed a commit that referenced this pull request Mar 19, 2024
snaps: skip usns for `base: core24` snaps
Saviq pushed a commit that referenced this pull request Jan 10, 2025
snaps: skip usns for `base: core24` snaps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants