Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

robot: build a WaylandRobot wrapper #92

Closed
wants to merge 6 commits into from
Closed

robot: build a WaylandRobot wrapper #92

wants to merge 6 commits into from

Conversation

Saviq
Copy link
Collaborator

@Saviq Saviq commented Feb 9, 2024 •
edited
Loading

No description provided.

@codecov Codecov
Copy link

codecov bot commented Feb 9, 2024 •
edited
Loading

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (c7ae89a) 63.88% compared to head (81c0231) 64.22%.
Report is 3 commits behind head on main.

Files Patch % Lines
mir-ci/mir_ci/robot_wrapper.py 70.00% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
+ Coverage   63.88%   64.22%   +0.34%     
==========================================
  Files          11       12       +1     
  Lines         742      766      +24     
  Branches      103      104       +1     
==========================================
+ Hits          474      492      +18     
- Misses        243      249       +6     
  Partials       25       25

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Saviq Saviq changed the title bandwidth: make app_dragged use robot robot: build a WaylandRobot wrapper Feb 9, 2024
@Saviq Saviq marked this pull request as ready for review February 9, 2024 18:56
@Saviq Saviq requested a review from a team as a code owner February 9, 2024 18:56
@Saviq Saviq requested a review from hbatagelo February 9, 2024 19:45
hbatagelo
hbatagelo approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@hbatagelo hbatagelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat stuff.

When I run locally, the dbus-run-session -- python3 fails to open python3, but it seems fine in the CI, so...

@Saviq
Copy link
Collaborator Author

Saviq commented Feb 9, 2024

When I run locally, the dbus-run-session -- python3 fails to open python3, but it seems fine in the CI, so...

Oh that sneaked in, will revert.

@hbatagelo
Copy link
Contributor

It opens without the new session, but the font/decoration is now different. Probably needs more tweaking in the keyfile.
Screenshot from 2024-02-09 17-48-01

@Saviq
Copy link
Collaborator Author

Saviq commented Feb 9, 2024

It opens without the new session, but the font/decoration is now different. Probably needs more tweaking in the keyfile.

Yeah this app isn't isolated yet - I should do it here to have a better chance of matching. Will improve.

@Saviq Saviq marked this pull request as draft February 9, 2024 21:59
@Saviq Saviq force-pushed the robot-dragged branch 2 times, most recently from 0982fe4 to a9356cd Compare February 9, 2024 22:06
@Saviq Saviq force-pushed the robot-dragged branch 2 times, most recently from b67e0c7 to 912e7b3 Compare February 22, 2024 06:53
@Saviq Saviq closed this Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbatagelo hbatagelo hbatagelo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Saviq @hbatagelo