-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
screencopy: give template and screenshot a width #96
Conversation
Otherwise a larger screenshots overflows heavily.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #96 +/- ##
=======================================
Coverage 63.88% 63.88%
=======================================
Files 11 11
Lines 742 742
Branches 103 103
=======================================
Hits 474 474
Misses 243 243
Partials 25 25 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but the template looks huge at width=100%. I'd prefer images that don't overflow not to be scaled up. I've made a suggestion to account for that. WDYT?
Co-authored-by: Harlen Batagelo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but the template looks huge at width=100%. I'd prefer images that don't overflow not to be scaled up. I've made a suggestion to account for that. WDYT?
You're right, of course. Thanks!
screencopy: give template and screenshot a width
screencopy: give template and screenshot a width
Otherwise a larger screenshots overflows heavily.