Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

screencopy: give template and screenshot a width #96

Merged
merged 3 commits into from
Feb 21, 2024
Merged

Conversation

Saviq
Copy link
Collaborator

@Saviq Saviq commented Feb 20, 2024

Otherwise a larger screenshots overflows heavily.

Otherwise a larger screenshots overflows heavily.
@Saviq Saviq requested a review from a team as a code owner February 20, 2024 14:19
@Saviq Saviq requested a review from hbatagelo February 20, 2024 14:19
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (baa7e3c) 63.88% compared to head (c7ae89a) 63.88%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #96   +/-   ##
=======================================
  Coverage   63.88%   63.88%           
=======================================
  Files          11       11           
  Lines         742      742           
  Branches      103      103           
=======================================
  Hits          474      474           
  Misses        243      243           
  Partials       25       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@hbatagelo hbatagelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but the template looks huge at width=100%. I'd prefer images that don't overflow not to be scaled up. I've made a suggestion to account for that. WDYT?

Co-authored-by: Harlen Batagelo <[email protected]>
Copy link
Collaborator Author

@Saviq Saviq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but the template looks huge at width=100%. I'd prefer images that don't overflow not to be scaled up. I've made a suggestion to account for that. WDYT?

You're right, of course. Thanks!

@Saviq Saviq added this pull request to the merge queue Feb 21, 2024
Merged via the queue into main with commit ca193fb Feb 21, 2024
12 of 14 checks passed
@Saviq Saviq deleted the screencopy-log-width branch February 21, 2024 15:18
Saviq added a commit that referenced this pull request Mar 19, 2024
screencopy: give template and screenshot a width
Saviq added a commit that referenced this pull request Jan 10, 2025
screencopy: give template and screenshot a width
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants