Integrate with Starbase

rockcraft/cli.py

@@ -36,10 +36,10 @@ def run() -> int:
 
     app = _create_app()
 
-    return app.run()
+    return app.run()  # type: ignore[no-any-return]
 
 
-def _create_app():  # noqa: ANN202
+def _create_app():  # type: ignore[no-untyped-def] # noqa: ANN202
     # pylint: disable=import-outside-toplevel
     # Import these here so that the script that generates the docs for the
     # commands doesn't need to know *too much* of the application.

rockcraft/models/project.py

@@ -32,7 +32,7 @@
 import yaml
 from craft_application.models import BuildInfo
 from craft_application.models import Project as BaseProject
-from craft_archives import repo
+from craft_archives import repo  # type: ignore[import-untyped]
 from craft_providers import bases
 from pydantic_yaml import YamlModelMixin
 
@@ -50,8 +50,10 @@
 class Platform(pydantic.BaseModel):
     """Rockcraft project platform definition."""
 
-    build_on: pydantic.conlist(str, unique_items=True, min_items=1) | None
-    build_for: pydantic.conlist(str, unique_items=True, min_items=1) | None
+    build_on: pydantic.conlist(str, unique_items=True, min_items=1) | None  # type: ignore[valid-type]
+    build_for: pydantic.conlist(  # type: ignore[valid-type]
+        str, unique_items=True, min_items=1
+    ) | None
 
     class Config:  # pylint: disable=too-few-public-methods
         """Pydantic model configuration."""
@@ -188,7 +190,7 @@ def _validate_license(cls, rock_license: str) -> str:
             raise ProjectValidationError(
                 f"License {rock_license} not valid. It must be valid and in SPDX format."
             )
-        return lic.id
+        return str(lic.id)
 
     @pydantic.validator("title", always=True)
     @classmethod
@@ -337,7 +339,12 @@ def _validate_entrypoint_service(
                 "a valid Pebble service."
             )
 
-        command = values.get("services")[entrypoint_service].command
+        services = values.get("services")
+        if services:
+            command = services[entrypoint_service].command
+        else:
+            raise ProjectValidationError("The project does not define any services.")
+
         command_sh_args = shlex.split(command)
         # optional arg is surrounded by brackets, so check that they exist in the
         # right order
@@ -432,7 +439,7 @@ def unmarshal(cls, data: dict[str, Any]) -> "Project":
 
     def generate_metadata(
         self, generation_time: str, base_digest: bytes
-    ) -> tuple[dict, dict]:
+    ) -> tuple[dict[str, Any], dict[str, Any]]:
         """Generate the ROCK's metadata (both the OCI annotation and internal metadata.
 
         :param generation_time: the UTC time at the time of calling this method

rockcraft/oci.py

@@ -295,13 +295,14 @@ def add_user(
             emit.progress(f"Adding user {username}:{uid} with group {username}:{uid}")
             self.add_layer(tag, Path(tmpfs))
 
-    def stat(self) -> dict[Any, Any]:
+    def stat(self) -> dict[str, Any]:
         """Obtain the image statistics, as reported by "umoci stat --json"."""
         image_path = self.path / self.image_name
-        output = _process_run(
+        output: bytes = _process_run(
             ["umoci", "stat", "--json", "--image", str(image_path)]
         ).stdout
-        return json.loads(output)
+        result: dict[str, Any] = json.loads(output)
+        return result
 
     @staticmethod
     def digest(source_image: str) -> bytes:
@@ -598,7 +599,7 @@ def _inject_architecture_variant(image_path: Path, variant: str) -> None:
     tl_index_path.write_bytes(json.dumps(tl_index).encode("utf-8"))
 
 
-def _process_run(command: list[str], **kwargs: Any) -> subprocess.CompletedProcess:
+def _process_run(command: list[str], **kwargs: Any) -> subprocess.CompletedProcess[Any]:
     """Run a command and handle its output."""
     if not Path(command[0]).is_absolute():
         command[0] = get_snap_command_path(command[0])

rockcraft/plugins/python_plugin.py

@@ -75,7 +75,7 @@ class PythonPlugin(python_plugin.PythonPlugin):
     @override
     def _should_remove_symlinks(self) -> bool:
         """Overridden because for ubuntu bases we must always remove the symlinks."""
-        return self._part_info.base != "bare"
+        return bool(self._part_info.base != "bare")
 
     @override
     def _get_system_python_interpreter(self) -> str | None:

rockcraft/services/lifecycle.py

@@ -21,11 +21,11 @@
 from typing import Any, cast
 
 from craft_application import LifecycleService
-from craft_archives import repo
+from craft_archives import repo  # type: ignore[import-untyped]
 from craft_cli import emit
 from craft_parts import Features, LifecycleManager, Step, callbacks
 from craft_parts.errors import CallbackRegistrationError
-from craft_parts.infos import ProjectInfo
+from craft_parts.infos import ProjectInfo, StepInfo
 from overrides import override
 
 from rockcraft import layers
@@ -111,10 +111,12 @@ def _install_overlay_repositories(overlay_dir: Path, project_info: ProjectInfo)
         )
 
 
-def _post_prime_callback(step_info) -> bool:
+def _post_prime_callback(step_info: StepInfo) -> bool:
     prime_dir = step_info.prime_dir
-    files = step_info.state.files
     base_layer_dir = step_info.rootfs_dir
+    files: set[str]
+
+    files = step_info.state.files if step_info.state else set()
 
     layers.prune_prime_files(prime_dir, files, base_layer_dir)
     return True

rockcraft/usernames.py

@@ -16,6 +16,7 @@
 
 """List of allowed shared usernames/UIDs (analogously to SnapD)."""
 
+
 import pydantic
 
 
@@ -38,7 +39,7 @@ def _validate_run_user(cls, username: str) -> str:
 
         return username
 
-    def get_dict(self) -> dict:
+    def get_dict(self) -> dict[str, dict[str, int]]:
         """Cast the object into a dict using the username as the key."""
         return {self.username: {"uid": self.uid}}