Generate prometheus metrics for flask and add metrics endpoint #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plars
force-pushed
the
flask-prometheus
branch
from
7f45f9e
to
0409aee
Compare
nadzyah
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a /metrics route for prometheus to pull lots of data about what flask is doing, and also a few testflinger things like job submissions. This can be extended if we want to add more things.
Resolved issues
N/A
Documentation
N/A (the more interesting bits will come when we hook it up to grafana)
Web service API changes
Technically, yes it adds
/metricsbut it's only meant to be consumed by prometheus and is a well-known interface for anything that uses prometheus metrics. It's not a Testflinger APITests
I've hooked this up to a local prometheus/grafana instance and was able to get data from it