Update tf-cleanup for this branch to keep current with PR#382 that was just merged #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now that we merged support for releasing maas devices after the run is complete, we need to ensure that the cleanup step actually runs properly. Previously it was just removing the test container if it exists, but now we need to have it call
testflinger-device-connectors cleanupin case there's something to do for the phase.This has already been fixed in the tf-cleanup script for main, but we need to fix it here too for the newer style agent hosts. This is just so that things don't revert back to an older version of this script that lacks this support once we do merge this branch into main.
Resolved issues
N/A
Documentation
N/A
Web service API changes
N/A
Tests
I tested this in an environment that uses the newer agent hosts and it worked. I have already deployed the change for releasing maas nodes in the server lab so I updated this script there already and it correctly releases the system at the end of the job.