Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement /credentials/shop/manage as flask view #13422

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

britneywwc
Copy link
Contributor

@britneywwc britneywwc commented Jan 3, 2024

Done

  • Blocked by Implement /credentials/shop/ as flask view #13464
  • Implementing credentials/shop/manage in Flask view, previously a React App
  • Redesign tab selection to dropdown select
  • Remove the option to rotate/redeem key if key has expired
  • Update tooltip message when key is copied

QA

Issue / Card

Fixes WD-7950, WD-9176

Help

QA steps - Commit guidelines

@webteam-app
Copy link

Demo starting at https://ubuntu-com-13422.demos.haus

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.46%. Comparing base (e93384d) to head (0fdaed9).
Report is 3 commits behind head on main.

Current head 0fdaed9 differs from pull request most recent head ed12542

Please upload reports for the commit ed12542 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13422      +/-   ##
==========================================
+ Coverage   74.12%   74.46%   +0.33%     
==========================================
  Files         107      107              
  Lines        2864     2847      -17     
  Branches      957      948       -9     
==========================================
- Hits         2123     2120       -3     
+ Misses        715      703      -12     
+ Partials       26       24       -2     

see 11 files with indirect coverage changes

@britneywwc britneywwc force-pushed the flask-credentials-shop branch from 65eeb79 to 8d3ee7f Compare January 4, 2024 10:39
@britneywwc britneywwc changed the title WIP: Implement flask view for credentials shop Implement flask view for credentials shop Jan 4, 2024
@britneywwc britneywwc force-pushed the flask-credentials-shop branch 6 times, most recently from 2239163 to 59fe5b7 Compare January 10, 2024 05:43
@britneywwc britneywwc changed the title Implement flask view for credentials shop Implement /credentials/shop/manage as flask view Jan 10, 2024
@britneywwc britneywwc force-pushed the flask-credentials-shop branch from 59fe5b7 to 50617e1 Compare January 11, 2024 08:10
@britneywwc britneywwc force-pushed the flask-credentials-shop branch 3 times, most recently from f755d81 to 57fd3d6 Compare January 19, 2024 18:11
@britneywwc britneywwc force-pushed the flask-credentials-shop branch from 57fd3d6 to aa0c0be Compare January 19, 2024 18:27
@britneywwc britneywwc force-pushed the flask-credentials-shop branch from 245a61c to 0280423 Compare February 19, 2024 07:48
@britneywwc britneywwc force-pushed the flask-credentials-shop branch 2 times, most recently from 9d5bb70 to e311d65 Compare April 12, 2024 04:53
@abhigyanghosh30 abhigyanghosh30 force-pushed the flask-credentials-shop branch from e311d65 to ed12542 Compare June 10, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants