Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested dropdowns no longer dismiss overlay #5473

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JuanFernandoCastaneda
Copy link
Contributor

@JuanFernandoCastaneda JuanFernandoCastaneda commented Feb 14, 2025

Done

For the non-mobile version of the component: closing a nested drop-down doesn't dismiss the overlay anymore. Now it is only dismissed when closing the root drop-down.

Fixes #5288

QA

  • Open any of the "sliding" patterns, for example /docs/examples/patterns/navigation/sliding-dark.
  • Open "LXCFS" menu, then "Nested Layer".
  • Close "Nested Layer" and compare the behavior with closing "LXCFS" directly.

Check if PR is ready for release

If this PR contains Vanilla SCSS or macro code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention
    • if existing APIs (CSS classes & macro APIs) are not changed it can be a bugfix release (x.x.X)
    • if existing APIs (CSS classes & macro APIs) are changed/added/removed it should be a minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) or macros should be listed on the what's new page.

Screenshots

This is the pattern I'm talking about:

image

@webteam-app
Copy link

JuanFernandoCastaneda is not a collaborator of the repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Closing nested dropdowns in sliding navigation dismisses overlay
2 participants