Fix onReorderEnd method (#59)

* Minor change * Update readme
canopas · Apr 30, 2024 · 7bfe779 · 7bfe779
1 parent ed916ef
commit 7bfe779
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,10 @@
+# 1.0.5 (Apr 30, 2024)
+
+# Changelog
+
+## Bug Fixes
+- Fix `onReorderEnd` callback not being called after reordering is completed.
+
 # 1.0.4 (Apr 14, 2024)
 
 # Changelog

diff --git a/example/lib/home_page.dart b/example/lib/home_page.dart
@@ -176,6 +176,12 @@ class _HomePageState extends State<HomePage> {
                             list.insert(newIndex, user);
                           });
                         },
+                        onReorderEnd: (int index) {
+                          print(" End index :  $index");
+                        },
+                        onReorderStart: (int index) {
+                          print(" Start index :  $index");
+                        },
                         proxyDecorator: proxyDecorator
 
                         /*  A custom builder that is for inserting items with animations.

diff --git a/lib/src/builder/motion_animated_builder.dart b/lib/src/builder/motion_animated_builder.dart
@@ -291,6 +291,7 @@ class MotionBuilderState extends State<MotionBuilder>
   }
 
   void _dragEnd(_DragInfo item) {
+    widget.onReorderEnd?.call(_insertIndex!);
     setState(() => _finalDropPosition = _itemOffsetAt(_insertIndex!));
   }
 

diff --git a/lib/src/component/motion_animated_content.dart b/lib/src/component/motion_animated_content.dart
@@ -85,8 +85,8 @@ class MotionAnimatedContentState extends State<MotionAnimatedContent>
         setState(() {
           visible = true;
         });
+        widget.updateMotionData?.call(widget.motionData);
       }
-      widget.updateMotionData?.call(widget.motionData);
     });
     super.didUpdateWidget(oldWidget);
   }

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -1,6 +1,6 @@
 name: animated_reorderable_list
 description: A Flutter Reorderable Animated List with simple implementation and smooth transition.
-version: 1.0.4
+version: 1.0.5
 repository: https://github.com/canopas/animated_reorderable_list
 
 environment:
-Original file line number
+Diff line change
@@ Expand Up / @@ -291,6 +291,7 @@ class MotionBuilderState extends State<MotionBuilder> @@
       }
       void _dragEnd(_DragInfo item) {
+        widget.onReorderEnd?.call(_insertIndex!);
         setState(() => _finalDropPosition = _itemOffsetAt(_insertIndex!));
       }
@@ Expand Down @@