Remove firebase ad id usage #71
Conversation
WalkthroughThe pull request involves a modification to the Android application's manifest file. Specifically, a new XML namespace for tools has been added, and the permission for Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
app/android/app/src/main/AndroidManifest.xml (1)
Line range hint
13-15: Privacy Enhancement: Comprehensive approach to ad tracking removalThe combination of removing the AD_ID permission and disabling analytics ad ID collection via meta-data shows a comprehensive approach to preventing advertising tracking. This aligns well with modern privacy best practices.
Consider documenting these privacy-enhancing changes in your app's privacy policy and user documentation.
Also applies to: 48-50
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
app/android/app/src/main/AndroidManifest.xml(1 hunks)
🔇 Additional comments (2)
app/android/app/src/main/AndroidManifest.xml (2)
1-2: LGTM: Correct namespace declaration
The tools namespace is properly declared and correctly positioned at the manifest level, which is required for the permission removal operation.
Line range hint 13-15: LGTM: Proper removal of AD_ID permission
The permission removal is implemented correctly using tools:node="remove". This change enhances user privacy by preventing access to the advertising ID.
Let's verify there are no remaining references to advertising ID in the codebase:
✅ Verification successful
LGTM: AD_ID permission removal is safe
The codebase scan shows that:
- The only references to AD_ID are in the AndroidManifest.xml where we're explicitly removing it
- There's a corresponding analytics configuration to disable ad ID collection
- The build.gradle explicitly excludes the ads module from dependencies
This confirms that the permission removal is intentional and properly implemented across the codebase with no remaining dependencies on advertising ID functionality.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for any remaining references to advertising ID
echo "Checking for advertising ID references..."
rg -i "advertising|ad_id|adid|advertising_id" --type java --type kotlin --type xml
# Check for common ad-related dependencies in build files
echo "Checking build files for ad-related dependencies..."
rg -i "com\.google\.android\.gms\.ads|firebase-ads|play-services-ads" --type gradle
Length of output: 682
Summary by CodeRabbit
com.google.android.gms.permission.AD_IDfrom the application manifest.