Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in cds-compile.md #1556

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Fix typos in cds-compile.md #1556

merged 2 commits into from
Jan 14, 2025

Conversation

qmacro
Copy link
Collaborator

@qmacro qmacro commented Jan 13, 2025

Being a Latin scholar, I couldn't let this typo go by :-)

Being a Latin scholar, I couldn't let this typo go by :-)
@qmacro qmacro requested a review from smahati as a code owner January 13, 2025 11:34
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling Mistakes

  • node.js/cds-compile.md:445:44 Unknown word "coud"

Generally, for each spelling mistake there are 2 ways to fix it:

  1. Fix the spelling mistake and commit it.
  2. The word is incorrectly reported as misspelled → put the word on the project-words.txt list, located in the root project directory.

@@ -442,7 +442,7 @@ cds.on('compile.to.edmx', ...)
> As we're using Node's standard [EventEmitter](https://nodejs.org/api/events.html#asynchronous-vs-synchronous),
> event handlers execute **synchronously** in the order they are registered.

> [!tip] Note that several of these events coud be emitted for the same model, so ensure your handlers are idempodent.
> [!tip] Note that several of these events coud be emitted for the same model, so ensure your handlers are idempotent.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> [!tip] Note that several of these events coud be emitted for the same model, so ensure your handlers are idempotent.
> [!tip] Note that several of these events codd be emitted for the same model, so ensure your handlers are idempotent.

Or maybe one of these: coed, cold, cond, copd?

@qmacro qmacro changed the title Fix typo in cds-compile.md Fix typos in cds-compile.md Jan 13, 2025
@smahati
Copy link
Contributor

smahati commented Jan 14, 2025

Thank you @qmacro :)

@smahati smahati added this pull request to the merge queue Jan 14, 2025
Merged via the queue into main with commit 5072bd1 Jan 14, 2025
4 checks passed
@smahati smahati deleted the qmacro-patch-1 branch January 14, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants