cds.spawn: Make it clearer that the context is inherited #512
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the documentation of `cds.spawn` was referring to the argument `context` from `cds.tx`, while the documentation of `cds.tx` mentions the argument `ctx`. - add a sentence to make it explicit that, unless overriden, cds.spawn will inherit the surrounding context.
|
Unsure whether it would make sense to clarify whether recurring jobs running repeatedly would share the same correlation ID ( |
|
Hi @PierreFritsch , @sjvans: could you comment and review here? |
sjvans
reviewed
Nov 6, 2023
sjvans
reviewed
Nov 6, 2023
-> "inherits all values" in my suggestion |
Co-authored-by: sjvans <[email protected]>
renejeglinsky
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the documentation of cds.spawn more explicit regarding the context passed to background jobs:
cds.spawnwas referring to the argumentcontextfromcds.tx, while the documentation ofcds.txmentions the argumentctx.