-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get Started: Updates #662
Get Started: Updates #662
Conversation
Fully agree with replacing the TIP heading with the first sentence as you did. However, the query options sample is important enough to the flow of the guide to remain top-level imo. I fear if included in the tip box many users will skip this part. |
The tip is relevant to the other part, so maybe we could move the information out of the tip and into the main text. |
No. this needs to stay a positive eye catcher → hence tip |
As the orange in the link + the green in the tip have semantic and not just ornamental value I think the coloring here is fine, even if a bit colorful. Imo the tip is most helpful before the sentence explaining |
If the sentence explaining |
get-started/in-a-nutshell.md
Outdated
|
||
CAP-based services are full-fledged OData services out of the box. Without adding any provider implementation code, they translate OData request into corresponding database requests, and return the results as OData responses. | ||
http://localhost:4004/odata/v4/browse/Books?$search=Brontë&$select=title,author&$expand=currency($select=code,name,symbol)&$orderby=title |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At this point of the guide, we don't have any data yet. So this link doesn't show anything. Does it add value anyhow? Or should we move this section a bit?
if (context.getQuantity() > book.getStock()) | ||
throw new IllegalArgumentException(context.getQuantity() + " exceeds stock for book #" + book.getTitle()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rjayasinghe Is that fine for you?
Went through the guide and made some updates