-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs for new sap.common.Timezone
#686
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to timestamp, timezone is a single word, not two (see also MDM dosc)
→ Please change all definitions to Timezone
and adjust the docs
Well, the spelling is not that clear. IANA‘s time zone database (tzdata) and wiki use „time zone“ quite consistently: Tendency in modern US English seems to go for the compound „timezone“, but not in plural „time zones“: https://en.m.wiktionary.org/wiki/timezone |
c1771fb
to
820feae
Compare
sap.common.TimeZone
sap.common.Timezone
* Docs for new `sap.common.TimeZone` * Rename to `Timezone`. Add API links
* added TODOs * started to describe the new generic outbox API * fixed typos * described the configuration of custom outboxes * started to describe outboxing of arbitrary CAP services * Docs for new `sap.common.Timezone` (#686) * Docs for new `sap.common.TimeZone` * Rename to `Timezone`. Add API links * add internal fragment * added example for outboxing a service * detail changes to outboxing arbitrary CAP services * fixed typos * Update java/outbox.md Co-authored-by: BraunMatthias <[email protected]> * Update java/outbox.md Co-authored-by: BraunMatthias <[email protected]> * Update java/outbox.md Co-authored-by: BraunMatthias <[email protected]> * Update java/outbox.md Co-authored-by: BraunMatthias <[email protected]> * Update java/outbox.md Co-authored-by: BraunMatthias <[email protected]> * Apply suggestions from code review Co-authored-by: BraunMatthias <[email protected]> * added warning * fixed merge conflicts * described how to outbox custom CAP service events * fixed typo * minor changes * added anchor * added tip for using custom outbox when using multiple channels * Apply suggestions from code review Co-authored-by: Marc Becker <[email protected]> * changes after review * removed chapter regarding outboxing of custom CAP services * Update outbox.md * Apply suggestions from code review Co-authored-by: Marc Becker <[email protected]> * changes after code review * Apply suggestions from code review Co-authored-by: BraunMatthias <[email protected]> * changes after code review * editing --------- Co-authored-by: Christian Georgi <[email protected]> Co-authored-by: Rene Jeglinsky <[email protected]> Co-authored-by: BraunMatthias <[email protected]> Co-authored-by: Marc Becker <[email protected]>
* Update odata.md (#647) * Update odata.md * Update advanced/odata.md Co-authored-by: Johannes Vogel <[email protected]> --------- Co-authored-by: Johannes Vogel <[email protected]> * Fix ZSH layout in databases guide * Docs for new `sap.common.Timezone` (#686) * Docs for new `sap.common.TimeZone` * Rename to `Timezone`. Add API links * add internal fragment * make config schema public beta * Feature Matrix: added cds upgrade (#695) added cds upgrade * Domain Modeling: fix import (#696) fix import * css: sync numbers with code line height * Temporal: Fix query (#697) Update temporal-data.md * fix: ad-hoc options are not cached (#698) * fix: ad-hoc options are not cached * Update node.js/cds-connect.md --------- Co-authored-by: René Jeglinsky <[email protected]> * Make docu on @sql.append/prepend and string literals a bit more precise (#699) * Rework `cds bind` documentation (#654) * Improvements in `cds bind` documentation * Wording * Wording * More * Use `--to-app-services` * Update hybrid-testing.md * Update advanced/hybrid-testing.md * typo * no booo --------- Co-authored-by: René Jeglinsky <[email protected]> * Clarify cds-feature-xsuaa to cds-feature-identity switch (#701) Co-authored-by: René Jeglinsky <[email protected]> * Harmonize: Use Note: (#700) * use Note: * w/o note * use note * Fix missing index entries in Advanced page These entries point to pages outside of `advanced/`, so need to mention them explicitly. * Separate index page for Publishing APIs * Make wide tables flow over aside section * Use TS consistently in index pages * enrich docs for tokeninfo (#702) * java-generic-outbox (#691) * added TODOs * started to describe the new generic outbox API * fixed typos * described the configuration of custom outboxes * started to describe outboxing of arbitrary CAP services * Docs for new `sap.common.Timezone` (#686) * Docs for new `sap.common.TimeZone` * Rename to `Timezone`. Add API links * add internal fragment * added example for outboxing a service * detail changes to outboxing arbitrary CAP services * fixed typos * Update java/outbox.md Co-authored-by: BraunMatthias <[email protected]> * Update java/outbox.md Co-authored-by: BraunMatthias <[email protected]> * Update java/outbox.md Co-authored-by: BraunMatthias <[email protected]> * Update java/outbox.md Co-authored-by: BraunMatthias <[email protected]> * Update java/outbox.md Co-authored-by: BraunMatthias <[email protected]> * Apply suggestions from code review Co-authored-by: BraunMatthias <[email protected]> * added warning * fixed merge conflicts * described how to outbox custom CAP service events * fixed typo * minor changes * added anchor * added tip for using custom outbox when using multiple channels * Apply suggestions from code review Co-authored-by: Marc Becker <[email protected]> * changes after review * removed chapter regarding outboxing of custom CAP services * Update outbox.md * Apply suggestions from code review Co-authored-by: Marc Becker <[email protected]> * changes after code review * Apply suggestions from code review Co-authored-by: BraunMatthias <[email protected]> * changes after code review * editing --------- Co-authored-by: Christian Georgi <[email protected]> Co-authored-by: Rene Jeglinsky <[email protected]> Co-authored-by: BraunMatthias <[email protected]> Co-authored-by: Marc Becker <[email protected]> * Update dependency com.sap.cds:cds4j-api to v2.7.0 (#706) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * add new cds.fiori.draft_lock_timeout for configuration of draft lock (#694) cds.fiori.draft_lock_timeout Co-authored-by: René Jeglinsky <[email protected]> * Update dependency com.sap.cds:cds-services-api to v2.7.0 (#708) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Java occ (#693) * Java Optimistic Concurrency Control * typos * Apply suggestions from code review Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * builder API * comments from Evgeny * Apply suggestions from code review Co-authored-by: Evgeny Andreev <[email protected]> * typos * review comments * editing * Apply suggestions from code review Co-authored-by: Marc Becker <[email protected]> Co-authored-by: René Jeglinsky <[email protected]> * Update java/query-execution.md Co-authored-by: Adrian Görler <[email protected]> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: René Jeglinsky <[email protected]> Co-authored-by: Evgeny Andreev <[email protected]> Co-authored-by: Marc Becker <[email protected]> --------- Co-authored-by: Johannes Vogel <[email protected]> Co-authored-by: Steffen Waldmann <[email protected]> Co-authored-by: Christian Georgi <[email protected]> Co-authored-by: Christian Georgi <[email protected]> Co-authored-by: Steffen Weinstock <[email protected]> Co-authored-by: Marc Becker <[email protected]> Co-authored-by: Thomas Bonk <[email protected]> Co-authored-by: BraunMatthias <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Adrian Görler <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Evgeny Andreev <[email protected]> Co-authored-by: Mahati Shankar <[email protected]>
See cap/docs#593