Allow to retrieve ReaderSegments object from reader objects
#526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marmeladema
commented
Oct 19, 2024
| @@ -82,6 +82,10 @@ where | |||
| pub fn into_segments(self) -> S { | |||
| self.segments | |||
| } | |||
|
|
|||
| pub(crate) fn get_segments(&self) -> &S { | |||
There was a problem hiding this comment.
Not sure if this one should be public or not so i've kept it private for now.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #526 +/- ##
==========================================
+ Coverage 51.64% 52.44% +0.80%
==========================================
Files 69 70 +1
Lines 33735 34570 +835
==========================================
+ Hits 17422 18130 +708
- Misses 16313 16440 +127 ☔ View full report in Codecov by Sentry. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #524