Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

angular: remove modules #1947

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tom-wegener
Copy link
Contributor

@tom-wegener tom-wegener commented Jan 17, 2025

As discussed here is the stackblitz MR.

Updates

  • remove angular module files (*.module.ts)
  • update angular inside stackblitz to v19
  • replace the ChartModule import inside stackblitz with the import of the specific component
  • fix a wrong selector for the simple bar chart

Demo screenshot or recording

no visual changes

Copy link

netlify bot commented Jan 17, 2025

Deploy Preview for carbon-charts-core ready!

Name Link
🔨 Latest commit c215559
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-core/deploys/678f8eec2737120008666a3d
😎 Deploy Preview https://deploy-preview-1947--carbon-charts-core.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 17, 2025

Deploy Preview for carbon-charts-docs ready!

Name Link
🔨 Latest commit c215559
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-docs/deploys/678f8eec8649060008e2ec50
😎 Deploy Preview https://deploy-preview-1947--carbon-charts-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 17, 2025

Deploy Preview for carbon-charts-react ready!

Name Link
🔨 Latest commit c215559
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-react/deploys/678f8eec4d7a8e000738f55a
😎 Deploy Preview https://deploy-preview-1947--carbon-charts-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 17, 2025

Deploy Preview for carbon-charts-angular ready!

Name Link
🔨 Latest commit c215559
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-angular/deploys/678f8eec037de50008cb0ca7
😎 Deploy Preview https://deploy-preview-1947--carbon-charts-angular.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tom-wegener tom-wegener marked this pull request as ready for review January 17, 2025 12:15
@tom-wegener tom-wegener requested review from theiliad and a team as code owners January 17, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant