Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine Email and Phone fixed Issue for NoticeOnly #12196

Merged
merged 12 commits into from
Feb 5, 2025

Conversation

deathcave
Copy link
Contributor

Related Ticket(s)

Noitce & Choice w3 Publisher

Description

Notice & Choice is a legally required component to create a form where IBM collects its customer information.
This section shows the specific product's legal links, terms, and conditions. Along with this, it collects users' consent regarding communication preferences.

Changelog

New

Changed

  • Fixed notice only for NC_HIDDEN fields and punsStatus.
  • Removed support for older versions and backward compatibility
  • Removed combine-email-phone attribute.

Removed

@deathcave deathcave requested a review from a team as a code owner January 28, 2025 10:40
@deathcave deathcave requested review from bruno-amorim, marcelojcs and Valentin-Sorin-Nicolae and removed request for a team January 28, 2025 10:40
@deathcave
Copy link
Contributor Author

I have read the DCO document and I hereby sign the DCO.

Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for incomparable-wisp-8d6771 ready!

Name Link
🔨 Latest commit 4278eed
🔍 Latest deploy log https://app.netlify.com/sites/incomparable-wisp-8d6771/deploys/6798b40850d76300080a22d6
😎 Deploy Preview https://deploy-preview-12196--incomparable-wisp-8d6771.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for incomparable-wisp-8d6771 ready!

Name Link
🔨 Latest commit 638ef9e
🔍 Latest deploy log https://app.netlify.com/sites/incomparable-wisp-8d6771/deploys/67a3ca2f702de600097db570
😎 Deploy Preview https://deploy-preview-12196--incomparable-wisp-8d6771.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sanjitbauli sanjitbauli added feature flag test: CDN preview used for generating @carbon/ibmdotcom-web-components CDN for testing labels Jan 28, 2025
Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for ibm-dotcom-web-components-react-wrap ready!

Name Link
🔨 Latest commit 270f39e
🔍 Latest deploy log https://app.netlify.com/sites/ibm-dotcom-web-components-react-wrap/deploys/6798b45cd3030b00082bf6d5
😎 Deploy Preview https://deploy-preview-12196--ibm-dotcom-web-components-react-wrap.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for ibm-dotcom-web-components-react-wrap ready!

Name Link
🔨 Latest commit d593dc6
🔍 Latest deploy log https://app.netlify.com/sites/ibm-dotcom-web-components-react-wrap/deploys/6798b67f92416a0008b3e48a
😎 Deploy Preview https://deploy-preview-12196--ibm-dotcom-web-components-react-wrap.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 28, 2025

Deploy preview created for package IBM.com Web Components Deploy Preview CDN:
https://ibmdotcom-cdn.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/12196/index.html

Built with commit: 638ef9e4b5281fcf2e6f40275088d0b1f33f9145

Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for ibm-dotcom-web-components-react-wrap ready!

Name Link
🔨 Latest commit 638ef9e
🔍 Latest deploy log https://app.netlify.com/sites/ibm-dotcom-web-components-react-wrap/deploys/67a3ca2fa847cb0008864dce
😎 Deploy Preview https://deploy-preview-12196--ibm-dotcom-web-components-react-wrap.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 28, 2025

@Valentin-Sorin-Nicolae Valentin-Sorin-Nicolae added the Ready to merge Label for the pull requests that are ready to merge label Jan 29, 2025
@marcelojcs marcelojcs removed the Ready to merge Label for the pull requests that are ready to merge label Feb 5, 2025
Copy link

netlify bot commented Feb 5, 2025

Deploy Preview for ibm-dotcom-web-components ready!

Name Link
🔨 Latest commit 638ef9e
🔍 Latest deploy log https://app.netlify.com/sites/ibm-dotcom-web-components/deploys/67a3ca2f3692c300088e722b
😎 Deploy Preview https://deploy-preview-12196--ibm-dotcom-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@marcelojcs marcelojcs added the Ready to merge Label for the pull requests that are ready to merge label Feb 5, 2025
@kodiakhq kodiakhq bot merged commit de6de18 into carbon-design-system:main Feb 5, 2025
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature flag Ready to merge Label for the pull requests that are ready to merge test: CDN preview used for generating @carbon/ibmdotcom-web-components CDN for testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants